chore: add mutagen gRPC client#111
Merged
Merged
Conversation
This was referenced Mar 13, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ethanndickson
force-pushed
the
ethan/mutagen-grpc-client
branch
from
c7e529d to
008f582
Compare
ethanndickson
commented
Mar 13, 2025
| mutagen_tag="$1" | ||
|
|
||
| # TODO: Change this to `coder/mutagen` once we add a version tag there | ||
| repo="mutagen-io/mutagen" |
Member
Author
There was a problem hiding this comment.
Same deal as on the Windows repo, I'll make a follow-up once we have a tag.
ethanndickson
commented
Mar 13, 2025
|
|
||
| # This script vendors the Mutagen proto files from a tag on a Mutagen GitHub repo. | ||
| # It is very similar to `Update-Proto.ps1` on `coder/coder-desktop-windows`. | ||
| # It's very unlikely that we'll use this script regularly. |
Member
Author
There was a problem hiding this comment.
In saying that, we could not commit any part of this SDK to the repo, and just generate them as part of make setup? I'm not sure which I'd prefer.
The Windows repo commits the .proto files (but the C# compiler can handle them at compile time), and we already commit .pb.swift files here for the VPN protocol.
ethanndickson
changed the base branch from
ethan/replace-dir-spaces
to
graphite-base/111
ethanndickson
force-pushed
the
graphite-base/111
branch
from
8bc8be7 to
e8e4004
Compare
ethanndickson
force-pushed
the
ethan/mutagen-grpc-client
branch
from
008f582 to
b7a0a77
Compare
ethanndickson
force-pushed
the
ethan/mutagen-grpc-client
branch
from
b7a0a77 to
26c3593
Compare
deansheather
approved these changes
Mar 13, 2025
Member
deansheather
left a comment
deansheather
left a comment
There was a problem hiding this comment.
I think it's fine that you're committing them all to the repo. Your call on what to do though
ThomasK33
approved these changes
Mar 13, 2025
ethanndickson
force-pushed
the
ethan/mutagen-grpc-client
branch
from
31aeac0 to
1f5dd2e
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#379
Much like in coder/coder-desktop-windows#48, this PR adds
mutagen-proto.shwhich finds all required files, followingimports.Right now, we use this client to stop the daemon over gRPC.