Skip to content

🤖 fix: remove duplicate server arg from Coder control plane #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasK33 merged 1 commit into from
Feb 10, 2026
Merged

🤖 fix: remove duplicate server arg from Coder control plane #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/controller/codercontrolplane_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func (r *CoderControlPlaneReconciler) reconcileDeployment(ctx context.Context, c
image = defaultCoderImage
}

args := []string{"server", "--http-address=0.0.0.0:3000"}
args := []string{"--http-address=0.0.0.0:3000"}
args = append(args, coderControlPlane.Spec.ExtraArgs...)

deployment.Spec.Replicas = &replicas
Expand Down
15 changes: 13 additions & 2 deletions internal/controller/codercontrolplane_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package controller_test

import (
"context"
"reflect"
"strings"
"testing"

Expand Down Expand Up @@ -45,8 +46,9 @@ func TestReconcile_ExistingResource(t *testing.T) {
Namespace: "default",
},
Spec: coderv1alpha1.CoderControlPlaneSpec{
Image: "test-image:latest",
Replicas: &replicas,
Image: "test-image:latest",
Replicas: &replicas,
ExtraArgs: []string{"--prometheus-enable=false"},
Service: coderv1alpha1.ServiceSpec{
Port: 8080,
},
Expand Down Expand Up @@ -86,6 +88,15 @@ func TestReconcile_ExistingResource(t *testing.T) {
t.Fatalf("expected deployment replicas %d, got %#v", replicas, deployment.Spec.Replicas)
}

if len(deployment.Spec.Template.Spec.Containers) != 1 {
t.Fatalf("expected one container in deployment pod spec, got %d", len(deployment.Spec.Template.Spec.Containers))
}
container := deployment.Spec.Template.Spec.Containers[0]
expectedArgs := []string{"--http-address=0.0.0.0:3000", "--prometheus-enable=false"}
if !reflect.DeepEqual(container.Args, expectedArgs) {
t.Fatalf("expected container args %v, got %v", expectedArgs, container.Args)
}

service := &corev1.Service{}
if err := k8sClient.Get(ctx, types.NamespacedName{Name: cp.Name, Namespace: cp.Namespace}, service); err != nil {
t.Fatalf("expected service to be reconciled: %v", err)
Expand Down