🤖 fix: reduce noisy reconcile errors and align CNPG access URL#44
Merged
Conversation
Change-Id: Iae9bd07b436ee7b24eaac7b3a40baed45883dd96 Signed-off-by: Thomas Kosiewski <tk@coder.com>
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change reduces noisy controller logs by removing immediate cached read-after-write lookups after successful
CreateOrUpdateoperations in the control plane and workspace proxy reconcilers. It also aligns the CloudNativePG example to usehttp://localhost:3000forCODER_ACCESS_URLand matching quickstart instructions.Background
When reconcilers created resources and immediately performed a cached
Get, controller-runtime cache propagation could briefly lag API writes, producing transientNotFounderrors. In dev logging mode those surfaced with stack traces that looked panic-like despite being recoverable retries.Implementation
CreateOrUpdateGetcalls in:internal/controller/codercontrolplane_controller.gointernal/controller/workspaceproxy_controller.goexamples/cloudnativepg/codercontrolplane.yaml(CODER_ACCESS_URL=http://localhost:3000)examples/cloudnativepg/README.md(port-forward/open URL/URL note updated to3000)Validation
make testmake test-integrationmake buildmake lintcoderService, verified recreation without newReconciler errorlog lines.make verify-vendorcurrently fails in this environment due an upstream checksum mismatch while runninggo mod tidyforgithub.com/MirrexOne/unqueryvet v1.4.0(downloaded checksum differs from the existinggo.sumentry).Risks
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.00