🤖 fix: unblock operator access token secret bootstrap#51
Merged
Conversation
Collect and close organization rows before executing membership upserts in the same transaction. This avoids lib/pq protocol errors during operator-access bootstrap and allows the operator token secret to be created. Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with [`mux`](https://github.com/coder/mux) • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `bash.00`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.00 --> Change-Id: I47d6a3c644be463a0b81c0720b05b61897200154
Member
Author
|
@codex review Please review this fix for operator token bootstrap in |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes operator-access bootstrap so the controller can reliably create the generated operator API token Secret for
CoderControlPlaneresources.Background
While validating the CloudNativePG example, operator access remained pending and no
<name>-operator-tokenSecret was created. The bootstrap provisioner hit a lib/pq protocol error while ensuring organization memberships.Implementation
ensureOperatorMembershipsininternal/coderbootstrap/operator_access_postgres.goto:Validation
make testmake buildmake lintmake verify-vendorcurrently fails in this environment due an upstream module checksum mismatch unrelated to this change:github.com/MirrexOne/unqueryvet@v1.4.0coder-operator-tokenSecret created incodernamespacestatus.operatorAccessReady: truestatus.operatorTokenSecretRef.name: coder-operator-tokenRisks
Low risk. Change is localized to operator-access bootstrap transaction sequencing; behavior is unchanged aside from eliminating a driver/protocol failure path.
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.00