🤖 fix: stop generating aggregation CRDs in manifests#68
Merged
Conversation
Stop generating aggregation.coder.com CRDs into config/crd/bases and delete previously generated aggregation CRD manifests. This makes `kubectl apply -f config/crd/bases/` safe for demo workflows while keeping docs approachable. Also add a fail-fast guard in hack/kind-dev.sh that detects stale APIService+aggregation-CRD conflicts and prints the exact cleanup command. --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.00`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.00 -->
Member
Author
|
@codex review Please review this change for manifest generation scope and demo reliability around APIService/CRD conflicts. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop generating
aggregation.coder.comCRDs intoconfig/crd/bases, delete the previously generated aggregation CRD manifests, and keep demo flows fail-fast when stale APIService/CRD conflicts exist.Background
For APIService-backed aggregated resources (
codertemplates,coderworkspaces), same-group CRDs inconfig/crd/basescaused unreliable read/discovery behavior in demos when both mechanisms were present. We wantkubectl apply -f config/crd/bases/to remain simple and safe.Implementation
hack/update-manifests.sh:./api/v1alpha1(operator-ownedcoder.com/*APIs)./...)config/crd/bases/aggregation.coder.com_codertemplates.yamlconfig/crd/bases/aggregation.coder.com_coderworkspaces.yamlhack/kind-dev.sh:APIService v1alpha1.aggregation.coder.com+ aggregation CRD coexistencekubectl apply -f config/crd/bases/) while keeping a focused troubleshooting note for stale conflict cleanup.Validation
make verify-vendormake testmake buildmake lintmake docs-checkmake manifestsbash -n ./hack/kind-dev.shCLUSTER_NAME=coder-k8s-smoke-20260212 ./hack/kind-dev.sh upRisks
Low-to-moderate:
config/crd/baseswill need to use the APIService path instead (which is the intended model).Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.00