🤖 fix: register internal aggregation kinds for SSA conversion#84
Merged
Conversation
Register CoderWorkspace/CoderTemplate kinds for aggregation.coder.com internal hub version in aggregated apiserver scheme setup. Also extend the NewScheme unit test to assert both v1alpha1 and __internal registrations so SSA conversion regressions are caught. --- _Generated with [`mux`](https://github.com/coder/mux) • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh`_ _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.49`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.49 -->
Member
Author
|
@codex review Please review this fix for aggregated API server internal scheme registration needed for SSA conversion. |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Register
aggregation.coder.cominternal (__internal) kinds forCoderWorkspaceandCoderTemplatein the aggregated apiserver scheme so SSA conversion can resolve hub types during API group install and request handling.Background
After fixing the earlier structured-merge typed schema error, SSA progressed further but failed with:
no kind "CoderTemplate" is registered for the internal version of group "aggregation.coder.com"The aggregated scheme only registered
v1alpha1kinds. Kubernetes generic apiserver conversion paths also require internal group registration.Implementation
internal/app/apiserverapp/apiserverapp.go:NewScheme(), addedschema.GroupVersion{Group: aggregation.coder.com, Version: runtime.APIVersionInternal}.scheme.AddKnownTypes(...)for:CoderWorkspaceCoderWorkspaceListCoderTemplateCoderTemplateListinternal/app/apiserverapp/apiserverapp_test.go:TestNewSchemeRegistersAggregationKindsto assert bothv1alpha1and__internalGVK recognition.Validation
make verify-vendormake testmake buildmake lintenv GOFLAGS=-mod=vendor go test ./internal/app/apiserverapp/...Risks
Low risk. The change is limited to scheme registration and a focused unit test update in the aggregated apiserver package. No storage behavior or request logic changed.
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhighGenerated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.49