🤖 fix: validate mode at stats schema boundaries #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
fix/stats-tab-mode-validation
branch
from
21cd051 to
5c9de0b
Compare
MuxMetadata.mode is typed as string (for future custom modes), but the stats Zod schemas only accept "plan" | "exec" | undefined. The code was casting mode without validation, which TypeScript allowed but Zod rejected at runtime. This caused ZodError spam on every stream delta event, since each delta triggers getSnapshot() which parses the schema. Fix: validate mode before storing/emitting - treat unknown modes as undefined for stats purposes.
ammar-agent
force-pushed
the
fix/stats-tab-mode-validation
branch
from
5c9de0b to
addbac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MuxMetadata.mode is typed as
string(for future custom modes), but the stats Zod schemas only accept"plan" | "exec" | undefined. The code was casting mode without validation, which TypeScript allowed but Zod rejected at runtime.This caused ZodError spam on every stream delta event, since each delta triggers
getSnapshot()which parses the schema.Fix: Validate mode before storing/emitting - treat unknown modes as undefined for stats purposes.
Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high