🤖 feat: persist all draft settings on New Workspace page #1258
+176
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All settings changed on the New Workspace page now persist as part of the draft until the message is sent: - Runtime mode selection (worktree/local/SSH) - Workspace name (generated or manual) - Auto-generate toggle state Added clearCreationDraftStorage() to centralize clearing draft state when workspace creation succeeds. Settings that already persisted (model, mode, thinking level, input text, images) continue to work as before.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Address review feedback - use updatePersistedState instead of direct localStorage.removeItem so that subscribers using usePersistedState with listener: true receive immediate updates.
- Move isGenerating and error keys from inline string literals to getDraftNameGeneratingKey() and getDraftNameErrorKey() functions - Add these ephemeral keys to getCreationDraftKeys() so they're cleared when workspace creation completes - Update test assertions for the new cleared keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All settings changed on the New Workspace page now persist as part of the draft until the message is sent:
draftRuntime:{projectPath}keydraftName:{projectPath}keydraftAutoGenerate:{projectPath}keyAdded
clearCreationDraftStorage()to centralize clearing all draft state when workspace creation succeeds.Settings that already persisted (model, mode, thinking level, input text, images) continue to work as before via their existing storage keys.
Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high