🤖 fix: default slash workflow project path args by ThomasK33 · Pull Request #3582 · coder/mux

ThomasK33 · 2026-06-17T11:44:13Z

Summary

Fix slash-command workflow starts so workflows that declare a projectPath argument receive the active workspace checkout path (including sub-project checkout paths) from the server-side workflow context instead of failing before a run is created.

Background

Running a workflow from a slash command could hit /workflows/start with only the typed workflow args. Workflows whose metadata.argsSchema required projectPath then failed during argument normalization with Workflow argument projectPath is required, which surfaced as a 500.

Implementation

Added invocation-context defaults to workflow argument normalization, applied only to schema-declared missing fields.
Passed the resolved active workflow execution checkout path as a slash-command-only projectPath default, including sub-project workspaces, without persisting hidden fields into command invocation metadata.
Added WorkflowArgsValidationError so workflow argument/schema validation failures map to oRPC BAD_REQUEST instead of generic internal errors.
Ran the simplify workflow and incorporated its small follow-up simplifications and malformed-schema validation coverage.

Validation

bun test src/node/services/workflows/WorkflowService.test.ts --test-name-pattern "applies invocation default args|workflow args"
bun test src/node/orpc/router.test.ts --test-name-pattern "router workflow routes"
bun test src/node/orpc/router.test.ts --test-name-pattern "projectPath defaults|active sub-project|bad request"
make static-check
workflow_run simplify --base origin/main

Risks

Low. The default context only applies to workflow args declared in a workflow schema and only when the caller omitted that field. Explicit user args and schema defaults keep their existing precedence, persisted slash-command args remain unchanged, and sub-project workspaces now receive the same active checkout path that workflow execution should operate on.

Generated with mux • Model: openai:gpt-5.5 • Thinking: xhigh • Cost: $19.51

Signed-off-by: Thomas Kosiewski <tk@coder.com>

ThomasK33 · 2026-06-17T11:44:21Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fed6052a61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ThomasK33 · 2026-06-17T11:51:11Z

Addressed the Codex finding about sub-project workspaces.

The slash workflow default now uses workflowExecutionProjectPath, which falls back to the active metadata.subProjectPath when no explicit workflow project path is supplied.
Added regression coverage for slash workflow projectPath defaults in an active sub-project workspace.
Re-ran make static-check and the targeted router sub-project/bad-request tests.

ThomasK33 · 2026-06-17T11:51:13Z

@codex review

Please take another look after the sub-project path default fix.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f7283962f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ThomasK33 · 2026-06-17T11:59:20Z

Addressed the follow-up Codex finding about worktree/SSH checkout paths.

The slash workflow default now derives projectPath from the resolved workspace checkout root and appends the active sub-project relative path when applicable.
Updated the sub-project regression test to use a separate workspace checkout and assert the checkout sub-project path, not the original source project identity.
Re-ran make static-check and the targeted router sub-project/bad-request tests.

ThomasK33 · 2026-06-17T11:59:22Z

@codex review

Please take another look after the checkout-path default fix.

chatgpt-codex-connector · 2026-06-17T12:04:16Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 8194961843

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

## Summary Long-lived auto-cleanup PR maintained by the **Auto-Cleanup Agent**. Each pass lands at most one extremely low-risk, behavior-preserving cleanup drawn from recently merged `main` activity, then advances the checkpoint below. ## This pass Replaced an inline terminal-status check in `WorkflowService.interruptRunOnAbort` (`src/node/services/workflows/WorkflowService.ts`) with the `isTerminalWorkflowRunStatus` helper introduced by coder#3587 ("show workflow-only sidebar activity"). The guard ```ts if ( run == null || run.status === "completed" || run.status === "failed" || run.status === "interrupted" ) { return; } ``` now reads `if (run == null || isTerminalWorkflowRunStatus(run.status))`. - **Behavior-preserving:** `isTerminalWorkflowRunStatus(status)` is defined as `status === "completed" || status === "failed" || status === "interrupted"` — byte-for-byte the same three-status disjunction (same short-circuit order, same boolean result), so the `run == null || ...` early-return is unchanged. - **Why it helps:** `isTerminalWorkflowRunStatus` is already the canonical terminal-status predicate everywhere else (`taskService.ts`, `tools/task_await.ts`); this was the only remaining hand-inlined copy in `WorkflowService`, so the dedup keeps the terminal-status set defined in exactly one place. - **Scoped:** one file, one guard; the helper was already exported from `@/common/types/workflow` and is now added to the existing import in `WorkflowService.ts` (next to the already-imported `isActiveWorkflowRunStatus`). ## Validation - `bun test src/node/services/workflows/WorkflowService.test.ts` — 58 pass / 0 fail. - `make static-check` — eslint, tsc (both configs), Prettier, and the generated workflow-runtime bundle drift check all pass. The only failing step is `fmt-shell-check`, which requires `shfmt` (not installed in this environment); no shell scripts were touched, so CI (which has `shfmt`) is unaffected. <details> <summary>Prior passes</summary> - Deduplicated the identical `workspaceId`-only metadata JSON Schema that three id-targeted host actions repeat in `src/node/services/workflows/workspaceHostActions.ts` into a module-level `WORKSPACE_ID_ONLY_INPUT_SCHEMA` constant (the third copy was introduced by coder#3583 when it added `workspace.unarchive`). Behavior-preserving: nothing mutates the metadata, and the shared constant has identical key order/values so the generated stub bundle is byte-identical (drift check passing). - Extracted a shared `BlockedBadge` component in `src/browser/features/Tools/WorkflowDefinitionToolCall.tsx` to deduplicate the `<WorkflowBadge tone="danger">blocked</WorkflowBadge>` markup that coder#3578 introduced verbatim in three spots. Also resolved a trivial rebase conflict from coder#3582 in `src/node/services/workflows/workflowArgs.ts`. - Deduplicated the repeated `"Workflow metadata.argsSchema.properties must be an object"` error string in `src/node/services/workflows/workflowArgs.ts` (added in coder#3575) into a module-level `ARGS_SCHEMA_PROPERTIES_ERROR_MESSAGE` constant. - Deduplicated the four mocked-module specifier strings in `src/browser/hooks/useModelsFromSettings.test.ts` into shared local constants so `installUseModelsModuleMocks()` / `restoreUseModelsModuleMocks()` can't drift (after coder#3574). - Removed a redundant `toggleWorkflowExpanded` wrapper in `src/browser/features/Tools/WorkflowRunToolCall.tsx`, left behind by coder#3571. - Deduplicated two repeated fallback error strings in `src/browser/components/AutomationModal/AutomationModal.tsx` (after coder#3560) into `SAVE_AUTOMATION_ERROR_MESSAGE` / `REMOVE_AUTOMATION_ERROR_MESSAGE` module-level constants. - Replaced a duplicated `"wfr_"` literal in `src/node/services/workflows/WorkflowRunner.ts` with the canonical `isWorkflowRunTaskId()` predicate from `src/node/services/tools/taskId.ts` (after coder#3565). - Removed a duplicated `"chat.jsonl"` literal in `src/node/services/analytics/etl.ts` by re-exporting `CHAT_FILE_NAME` from the canonical `src/common/constants/paths.ts` (after coder#3541). - Extracted a `harvestRecordTime` helper in `src/node/services/memoryConsolidationService.ts` so `findNewestHarvestRecord` and `pruneHarvestRecords` derive the `completedAt ?? startedAt` ordering key from one place (after coder#3558). </details> Auto-cleanup checkpoint: a7f047b --- _Generated with `mux` • Model: `anthropic:claude-opus-4-8` • Thinking: `xhigh` • Cost: `n/a`_  --------- Co-authored-by: mux-bot[bot] <264182336+mux-bot[bot]@users.noreply.github.com>

ThomasK33 added 2 commits June 17, 2026 11:31

fix workflow slash project path args

bf97d7e

simplify workflow arg validation handling

fed6052

Signed-off-by: Thomas Kosiewski <tk@coder.com>

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/node/orpc/router.ts Outdated

fix slash workflow subproject path defaults

2f72839

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/node/orpc/router.ts Outdated

fix slash workflow checkout project path defaults

8194961

ThomasK33 added this pull request to the merge queue Jun 17, 2026

Merged via the queue into main with commit 00383e2 Jun 17, 2026
40 of 42 checks passed

ThomasK33 deleted the fix-workflow-slash-project-path-args branch June 17, 2026 12:29

mux-bot Bot mentioned this pull request Jun 17, 2026

🤖 refactor: auto-cleanup #3559

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🤖 fix: default slash workflow project path args#3582

🤖 fix: default slash workflow project path args#3582
ThomasK33 merged 4 commits into
mainfrom
fix-workflow-slash-project-path-args

ThomasK33 commented Jun 17, 2026 •

edited

Loading

Uh oh!

ThomasK33 commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

ThomasK33 commented Jun 17, 2026

Uh oh!

ThomasK33 commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

ThomasK33 commented Jun 17, 2026

Uh oh!

ThomasK33 commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ThomasK33 commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Background

Implementation

Validation

Risks

Uh oh!

ThomasK33 commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ThomasK33 commented Jun 17, 2026

Uh oh!

ThomasK33 commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ThomasK33 commented Jun 17, 2026

Uh oh!

ThomasK33 commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ThomasK33 commented Jun 17, 2026 •

edited

Loading