chore: loading plan.json with string indexs (for_each)#132
Merged
Conversation
Emyrk
commented
May 21, 2025
Comment on lines
+146
to
+158
| case string: | ||
| keyStr, ok := resource.Index.(string) | ||
| if !ok { | ||
| return fmt.Errorf("unable to convert index '%v' for %q to a string", resource.Name, resource.Index) | ||
| } | ||
|
|
||
| if !existing.CanIterateElements() { | ||
| continue | ||
| } | ||
|
|
||
| instances := existing.AsValueMap() | ||
| instances[keyStr] = val | ||
| merged = cty.ObjectVal(instances) |
Member
Author
There was a problem hiding this comment.
Emyrk
commented
May 21, 2025
| @@ -0,0 +1,236 @@ | |||
| terraform { | |||
Member
Author
There was a problem hiding this comment.
This is a larger test main.tf taken from https://registry.coder.com/modules/coder/jetbrains-gateway
I prefer it being a bit complicated like this 👍
jaaydenh
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading in values from a
plan.json, loadingmapsandlistshave to be merged with an existing hcl context.Before this PR, only tuples were merged (integer indicies). This handles the map case.