fix(registry/coder-labs/modules/codex): align variable names with claude-code v5#885
Merged
Merged
Conversation
…ude-code v5 - Rename additional_mcp_servers to mcp to match claude-code's naming. - Change codex_version default from empty string to "latest" to match claude_code_version.
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the coder-labs/codex module’s MCP input naming with the newer claude-code convention and updates the Codex version default to use "latest" semantics. In this codebase, that mainly affects the module interface, install script template arguments, usage docs, and the script-level test fixture.
Changes:
- Renames the module input and install-script template variable from
additional_mcp_serverstomcp. - Changes
codex_version’s default from""to"latest"and simplifies its description. - Updates the README example and the Bun test fixture to use the renamed input.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
registry/coder-labs/modules/codex/scripts/install.sh.tftpl |
Swaps the decoded template argument and config append logic to read ARG_MCP. |
registry/coder-labs/modules/codex/README.md |
Updates the advanced usage example to pass mcp. |
registry/coder-labs/modules/codex/main.tf |
Renames the public Terraform variable and changes the default Codex version behavior. |
registry/coder-labs/modules/codex/main.test.ts |
Updates the MCP-related test setup to use the new input name. |
matifali
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns codex module variable names with the claude-code v5 conventions established in #861 and #879.
additional_mcp_serverstomcpto match claude-code's variable name.codex_versiondefault from""to"latest"to matchclaude_code_version.Type of Change
Module Information
Path:
registry/coder-labs/modules/codexBreaking change: [x] Yes [ ] No
Warning
Breaking change for anyone referencing
additional_mcp_serversby name. Since v5.0.0 was released and deleted on the same day (#879), this should have zero downstream impact.Testing & Validation
bun test)bun fmt)Related Issues
mcp_config_remote_pathsupport to codexThis PR was authored by Coder Agents.