Fix private room reconnect recovery - #179
Merged
Merged
Conversation
Avoid duplicate joins and preserve pending solves through private-room reconnects. Remember successful room passwords on-device, make same-room joins idempotent, surface password errors, redact credentials, and cover the recovery paths.
coder13
force-pushed
the
agent/private-room-rejoin
branch
from
July 12, 2026 15:24
857b44a to
9a1be2e
Compare
coder13
marked this pull request as ready for review
July 12, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A deploy temporarily disconnects active racers. Timing can continue locally, but the client must rejoin the room before submitting the saved result. Private rooms were especially fragile after a refresh because the password existed only in Redux memory, and duplicate buffered joins could leave the client disconnected from the room even after Socket.IO recovered.
This keeps the solve local during the interruption, retries room access with the last successfully used password, and submits the result once the room join succeeds. If that password is no longer valid, it is removed and the normal password form is shown.
Validation
yarn lintyarn test— 75 client tests and 79 server tests passedyarn build