chore(deps): bump golang.org/x/crypto from 0.46.0 to 0.52.0 - #1276
chore(deps): bump golang.org/x/crypto from 0.46.0 to 0.52.0#1276dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
🧰 Additional context used🔀 Multi-repo context codeready-toolchain/registration-service, codeready-toolchain/member-operator, codeready-toolchain/api, codeready-toolchain/toolchain-common, codeready-toolchain/toolchain-e2eLinked repositories findings
No direct cross-repository consumers of the bumped SSH/crypto APIs were identified. The relevant integration concern is dependency and Go-toolchain version skew across these modules. WalkthroughThis PR updates indirect ChangesGo dependency and toolchain update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 156: The Go version pin is inconsistent across the repo: go.mod is
already on 1.25.0, but Dockerfile.tools and .govulncheck.yaml still reference
1.24.13. Update the toolchain version used in Dockerfile.tools and the version
referenced by .govulncheck.yaml to match the go.mod pin, keeping the Go release
aligned everywhere these settings are defined.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 6855815c-3787-42a6-9dd7-5722095872f8
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
codeready-toolchain/registration-service(manual)codeready-toolchain/member-operator(manual)codeready-toolchain/api(manual)codeready-toolchain/toolchain-common(manual)codeready-toolchain/host-operator(manual)codeready-toolchain/toolchain-e2e(manual)
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: test
- GitHub Check: Build & push operator bundles & dashboard image for e2e tests
⚠️ CI failures not shown inline (2)
GitHub Actions: ci-build / 0_GolangCI Lint.txt: chore(deps): bump golang.org/x/crypto from 0.46.0 to 0.52.0
Conclusion: failure
##[group]run golangci-lint
Running [/home/runner/golangci-lint-2.1.6-linux-amd64/golangci-lint config path --config=./.golangci.yml] in [/home/runner/work/host-operator/host-operator] ...
Running [/home/runner/golangci-lint-2.1.6-linux-amd64/golangci-lint run --config=./.golangci.yml --verbose] in [/home/runner/work/host-operator/host-operator] ...
level=info msg="golangci-lint has version 2.1.6 built with go1.24.2 from eabc2638 on "
level=info msg="[config_reader] Used config file .golangci.yml"
level=info msg="[config_reader] Module name \"github.com/codeready-toolchain/host-operator\""
Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
Failed executing command with error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
##[error]golangci-lint exit with code 3
GitHub Actions: ci-build / GolangCI Lint: chore(deps): bump golang.org/x/crypto from 0.46.0 to 0.52.0
Conclusion: failure
##[group]run golangci-lint
Running [/home/runner/golangci-lint-2.1.6-linux-amd64/golangci-lint config path --config=./.golangci.yml] in [/home/runner/work/host-operator/host-operator] ...
Running [/home/runner/golangci-lint-2.1.6-linux-amd64/golangci-lint run --config=./.golangci.yml --verbose] in [/home/runner/work/host-operator/host-operator] ...
level=info msg="golangci-lint has version 2.1.6 built with go1.24.2 from eabc2638 on "
level=info msg="[config_reader] Used config file .golangci.yml"
level=info msg="[config_reader] Module name \"github.com/codeready-toolchain/host-operator\""
Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
Failed executing command with error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
##[error]golangci-lint exit with code 3
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
go.mod
🔀 Multi-repo context codeready-toolchain/registration-service, codeready-toolchain/member-operator, codeready-toolchain/api, codeready-toolchain/toolchain-common, codeready-toolchain/toolchain-e2e
Linked repositories findings
[::codeready-toolchain/registration-service::] go.mod:3,5,101 still pins go 1.24.4, toolchain go1.24.13, and golang.org/x/crypto v0.45.0 // indirect.
[::codeready-toolchain/member-operator::] go.mod:3,5,101 still pins go 1.24.4, toolchain go1.24.13, and golang.org/x/crypto v0.45.0 // indirect.
[::codeready-toolchain/api::] go.mod:3,5,101 still pins go 1.24.4, toolchain go1.24.13, and golang.org/x/crypto v0.45.0 // indirect.
[::codeready-toolchain/toolchain-common::] go.mod:3,5,101 still pins go 1.24.4, toolchain go1.24.13, and golang.org/x/crypto v0.45.0 // indirect.
[::codeready-toolchain/toolchain-e2e::] go.mod:3,5,101 still pins go 1.24.4, toolchain go1.24.13, and golang.org/x/crypto v0.45.0 // indirect.
No direct consumers of the bumped golang.org/x/crypto version were found in the linked repos; the main cross-repo context is that the other modules are still on the older Go/toolchain and crypto versions.
🔇 Additional comments (1)
go.mod (1)
124-134: LGTM!
| go 1.24.4 | ||
|
|
||
| toolchain go1.24.13 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n## go.mod\n'
grep -nE '^(go |toolchain |require |replace )' go.mod || true
printf '\n## openshift-ci/Dockerfile.tools\n'
grep -nE 'GOLANG_VERSION|go1\.' openshift-ci/Dockerfile.tools || true
printf '\n## .govulncheck.yaml\n'
grep -nE 'go1\.' .govulncheck.yaml || true
printf '\n## other go/toolchain references in repo\n'
rg -n --hidden --glob '!**/.git/**' 'go1\.24\.13|go 1\.25\.0|GOLANG_VERSION|govulncheck' .Repository: codeready-toolchain/host-operator
Length of output: 2402
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n## go.mod (top and toolchain-related lines)\n'
sed -n '1,30p;145,165p' go.mod
printf '\n## .govulncheck.yaml\n'
cat -n .govulncheck.yaml
printf '\n## any toolchain directive or go version references\n'
rg -n --hidden --glob '!**/.git/**' '^[[:space:]]*toolchain |^[[:space:]]*go [0-9]+\.[0-9]+|go1\.24\.13|go1\.25\.0|GOLANG_VERSION' go.mod .govulncheck.yaml openshift-ci/Dockerfile.tools .github/workflows/govulncheck.ymlRepository: codeready-toolchain/host-operator
Length of output: 3748
Sync the Go toolchain pins
go.mod is at Go 1.25.0, but openshift-ci/Dockerfile.tools still installs go1.24.13 and .govulncheck.yaml still refers to 1.24.13. Update those together so CI and vuln scans stay on the same release.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 156, The Go version pin is inconsistent across the repo:
go.mod is already on 1.25.0, but Dockerfile.tools and .govulncheck.yaml still
reference 1.24.13. Update the toolchain version used in Dockerfile.tools and the
version referenced by .govulncheck.yaml to match the go.mod pin, keeping the Go
release aligned everywhere these settings are defined.
Source: Path instructions
44a5033 to
dffe004
Compare
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.46.0 to 0.52.0. - [Commits](golang/crypto@v0.46.0...v0.52.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.52.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dffe004 to
8c1b692
Compare
|
Bumps golang.org/x/crypto from 0.46.0 to 0.52.0.
Commits
a1c0d99go.mod: update golang.org/x dependencies3c7c869ssh: fix deadlock on unexpected channel responses533fb3fssh: fix source-address critical option bypassabbc44dssh: fix incorrect operator ordere052873ssh: fix infinite loop on large channel writes due to integer overflowb61cf85ssh: enforce user presence verification for security keys9c2cd33ssh: enforce strict limits on DSA key parameters8907318ssh: reject RSA keys with excessively large moduliffd87b4ssh: fix panic when authority callbacks are nil4e7a738ssh: fix deadlock on unexpected global responsesSummary by CodeRabbit