feat(themes): port nvim color schemes#95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Red already bundles several VS Code-derived themes, but it was missing many of the color schemes configured in our Neovim theme picker. This adds Red-compatible theme JSON generated from the resolved highlight groups of the locally installed Neovim colorschemes so those schemes are available directly in Red.
The new bundle includes lackluster variants, Aura, Kanagawa variants, Zenbones variants, Rose Pine variants, tokyonight.nvim variants, Solarized Osaka, Cyberdream, Bamboo, Bluloco, Jellybeans, Nordic/Nordern/Onenord, and other configured Neovim schemes.
themes/THIRD_PARTY.mdnow documents the generated Neovim theme ports, license notices, and the schemes skipped because no redistributable upstream license was discoverable.How to Test
Run
git diff --name-only origin/master...HEAD -- "themes/*.json" | xargs -n1 jq empty.Expected: all newly added theme JSON files parse as strict JSON with no output.
Run
cargo test test_bundled_themes_parse.Expected: the bundled theme parser test passes, confirming all bundled themes parse and meet the picker selection contrast checks.
Run
rg "yorumi|nvim-tundra|poimandres" themes/THIRD_PARTY.md.Expected: the unlicensed Neovim schemes are listed only in the skipped section, not bundled as theme JSON files.