Redirect to sandbox wizard when deleting sandbox#1313
Merged
CompuIves merged 3 commits intocodesandbox:masterfrom Nov 18, 2018
pshrmn:delete-redirect
Merged
Redirect to sandbox wizard when deleting sandbox#1313CompuIves merged 3 commits intocodesandbox:masterfrom pshrmn:delete-redirect
CompuIves merged 3 commits intocodesandbox:masterfrom
pshrmn:delete-redirect
Conversation
pshrmn
commented
Nov 18, 2018
| addNotification('Sandbox deleted!', 'success'), | ||
| actions.redirectToNewSandbox, | ||
| set(props`id`, 'new'), | ||
| loadSandbox, |
Contributor
Author
There was a problem hiding this comment.
These two actions can be removed, correct? I'm not familiar enough with the architecture, but I believe that they are only used when loading a sandbox.
| history.push('/s/new'); | ||
| }, | ||
| redirectToSandboxWizard() { | ||
| history.push('/s'); |
Contributor
Author
There was a problem hiding this comment.
This might be better as a replace instead of push. Is there ever a reason that the user should be able to return to a deleted sandbox? Is there defined behavior for this?
Contributor
There was a problem hiding this comment.
I agree, we should make it a replace.
CompuIves
approved these changes
Nov 18, 2018
Contributor
CompuIves
left a comment
CompuIves
left a comment
There was a problem hiding this comment.
This is a great PR, long overdue. Thanks for making it! I left one small comment, after that it's ready for merge.
| history.push('/s/new'); | ||
| }, | ||
| redirectToSandboxWizard() { | ||
| history.push('/s'); |
Contributor
There was a problem hiding this comment.
I agree, we should make it a replace.
Contributor
|
Oops, clicked approve by accident 😅. |
lbogdan
reviewed
Nov 18, 2018
Contributor
|
Thanks a lot @pshrmn! |
Contributor
|
There were still lint errors... 😟 |
Contributor
|
Fixed! |
CompuIves
added a commit
to SaraVieira/codesandbox-client
that referenced
this pull request
Nov 23, 2018
Redirect to sandbox wizard when deleting sandbox (codesandbox#1313) * Redirect to sandbox wizard when deleting sandbox * Replace location when deleting * Trailing slash diff --git a/packages/app/src/app/store/modules/workspace/actions.js b/packages/app/src/app/store/modules/workspace/actions.js index f34698c..6444702 100644 --- a/packages/app/src/app/store/modules/workspace/actions.js +++ b/packages/app/src/app/store/modules/workspace/actions.js @@ -27,6 +27,10 @@ export function redirectToNewSandbox({ router }) { router.redirectToNewSandbox(); } +export function redirectToSandboxWizard({ router }) { + router.redirectToSandboxWizard(); +} + export function updateSandbox({ api, state }) { const sandboxId = state.get('editor.currentId'); const body = { diff --git a/packages/app/src/app/store/modules/workspace/sequences.js b/packages/app/src/app/store/modules/workspace/sequences.js index 3cfdbc1..17e097f 100644 --- a/packages/app/src/app/store/modules/workspace/sequences.js +++ b/packages/app/src/app/store/modules/workspace/sequences.js @@ -39,9 +39,7 @@ export const deleteSandbox = [ actions.deleteSandbox, set(state`workspace.showDeleteSandboxModal`, false),
SaraVieira
pushed a commit
to SaraVieira/codesandbox-client
that referenced
this pull request
Nov 23, 2018
* Redirect to sandbox wizard when deleting sandbox * Replace location when deleting * Trailing slash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR changes where the user is redirected after deleting a sandbox.
Fixes #1312
What is the current behavior?
The user is redirected to the new React template (
/s/new).What is the new behavior?
The user is redirected to the sandbox wizard (
/s).Checklist: