Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves tooltip accessibility by making tooltip content keyboard-reachable and better exposed to assistive technologies.
Changes:
- Refactors the tooltip trigger into a focusable button and associates it with tooltip content via
aria-describedby+role="tooltip". - Adds tooltip trigger styling and updates tooltip visibility CSS to support
:focus-within. - Adds an explicit accessible label for
ErrorTooltip.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/js/components/common/Tooltip.tsx |
Makes the tooltip trigger keyboard-focusable and wires up ARIA relationships for screen readers. |
src/css/common/_tooltips.scss |
Styles the new trigger element and ensures tooltips appear on focus within (keyboard). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, screen readers never announce tooltip text because it's a purely visual (CSS).
When you hover over the tooltip, it displays it. But it's not reachable for keyboard users.
With this PR, the tooltip can now be reached using your keyboard.
In addition, the accessibility tree is more clear: