Migrate metadata from setup.py and setup.cfg to pyproject.toml

[cclauss]

Migrate to pyproject.toml using ini2toml to do the file conversion and running validate-pyproject to validate the results.

• Currently flake8 is yet not compatible with pyproject.toml so move its config into .flake8

[peternewman]

You need to fix our CI tests please which currently call setup.py to install itself.

[cclauss]

You need to fix our CI tests please which currently call setup.py to install itself.

Yes. These calls to setup.py are exactly what we are trying to avoid. This confusing little dance between setup.py and make increases the attack surface.

This pull request must remain in DRAFT status until someone can propose an effective fix for make check-distutils. Unfortunately, my make-foo was not up to that task.

[peternewman]

Just adding a comment here to make sure we don't miss this, it will obviously be outdated when someone fixes it.

So in the same way as you changed the other commands, how do we run this command in the new format? If you can tell me on the command line, I should be able to make it work in the Makefile, i.e. I think it's a Python not a Make issue.

This page explains what it did, the correct answer might be that these particular commands are no longer required, but hopefully there's a similar set of tools to validate pyproject.toml we should switch to instead? It's interesting that we weren't validating the metadata itself before!

[cclauss]

Ahhh... I did not know that setup.py had a check command. The commit message mentions validate-pyproject.

I will update.

[peternewman]

Sorry @larsoner has also done this (and some other stuff) in #2523 .

I don't know which one we merge/use first...

[peternewman]

May as well leave some backwards compatibility...

Suggested change

	check-pyproject:
	check-distutils: check-pyproject
	check-pyproject:

[cclauss]

distutils will not be in py1.12 so this is probably a good time to change the name.

• https://docs.python.org/3/library/distutils.html

[peternewman]

Suggested change

	PHONY := all check check-dictionaries sort-dictionaries trim-dictionaries check-dictionary sort-dictionary trim-dictionary check-manifest check-pyproject flake8 pytest pypi clean
	PHONY := all check check-dictionaries sort-dictionaries trim-dictionaries check-dictionary sort-dictionary trim-dictionary check-manifest check-pyproject check-distutils flake8 pytest pypi clean

[cclauss]

This would run the code twice under two different names.

[larsoner]

I don't know which one we merge/use first...

Argh sorry I didn't see this! #2523 also has CI infrastructure to make releasing (hopefully!) trivial, so I'd rather merge that one.

[cclauss]

No troubles. Closing in favor of #2523.