Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
7cc0a7a
Support delimiter
TatianaFomina Apr 17, 2024
11de62f
Rename types, move types to popover-item folder
TatianaFomina Apr 19, 2024
738da13
Fix ts errors
TatianaFomina Apr 19, 2024
d73c9d4
Add tests
TatianaFomina Apr 19, 2024
10eed56
Review fixes
TatianaFomina Apr 19, 2024
eb3891a
Review fixes 2
TatianaFomina Apr 19, 2024
743c78e
Fix delimiter while search
TatianaFomina Apr 19, 2024
130c586
Fix flipper issue
TatianaFomina Apr 19, 2024
58fb475
Fix block tunes types
TatianaFomina Apr 19, 2024
abe5e6d
Fix types
TatianaFomina Apr 20, 2024
1f113da
tmp
TatianaFomina Apr 20, 2024
c8e2e01
Fixes
TatianaFomina Apr 20, 2024
6cebaf6
Merge branch 'feat/delimiter' into feat/new-convert-to
TatianaFomina Apr 20, 2024
df5ce10
Make search input emit event
TatianaFomina Apr 20, 2024
4f29cd4
Merge branch 'feat/delimiter' into feat/new-convert-to
TatianaFomina Apr 20, 2024
346a9a4
Fix types
TatianaFomina Apr 20, 2024
751e282
Merge branch 'feat/delimiter' into feat/new-convert-to
TatianaFomina Apr 20, 2024
b7080a6
Rename delimiter to separator
TatianaFomina Apr 20, 2024
e547249
Update chengelog
TatianaFomina Apr 20, 2024
e0f98e6
Merge branch 'feat/delimiter' into feat/new-convert-to
TatianaFomina Apr 20, 2024
48a50c4
Add convert to to block tunes
TatianaFomina Apr 21, 2024
5cb4b56
i18n
TatianaFomina Apr 21, 2024
112e8e0
Lint
TatianaFomina Apr 21, 2024
7b8491f
Fix tests
TatianaFomina Apr 21, 2024
18f6c68
Fix tests 2
TatianaFomina Apr 21, 2024
ffd768d
Tests
TatianaFomina Apr 21, 2024
e5e654c
Add caching
TatianaFomina Apr 21, 2024
a66d37b
Rename
TatianaFomina Apr 22, 2024
c79c029
Fix for miltiple toolbox entries
TatianaFomina Apr 24, 2024
158d68d
Merge branch 'next' into feat/new-convert-to
TatianaFomina Apr 24, 2024
8e5e992
Update changelog
TatianaFomina Apr 24, 2024
4dfa457
Update changelog
TatianaFomina Apr 25, 2024
53e4da0
Fix popover test
TatianaFomina Apr 25, 2024
49382e6
Fix flipper tests
TatianaFomina Apr 25, 2024
ab79dee
Fix popover tests
TatianaFomina Apr 25, 2024
96f8f6b
Remove type: 'default'
TatianaFomina Apr 25, 2024
ad0e9cf
Create isSameBlockData util
TatianaFomina Apr 25, 2024
65f34cf
Add testcase
TatianaFomina Apr 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename types, move types to popover-item folder
  • Loading branch information
TatianaFomina committed Apr 19, 2024
commit 11de62faa0ec8bed353d54dd6e478baf98a0c5fe
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { PopoverItemDefault } from './popover-item-default/popover-item-default'
import { PopoverItemDelimiter } from './popover-item-delimiter/popover-item-delimiter';

export * from './popover-item-default/popover-item-default.const';
export * from './popover-item.types';

/**
* Commoon type for popover items
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import Dom from '../../../../../dom';
import { IconDotCircle, IconChevronRight } from '@codexteam/icons';
import { PopoverItemDefault as PopoverItemDefaultParams, PopoverItem as PopoverItemParams } from '../popover-item.types';
import {
PopoverItemDefaultParams as PopoverItemDefaultParams,
PopoverItemParams as PopoverItemParams
} from '../popover-item.types';
import { css } from './popover-item-default.const';

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/**
* Represents popover item delimiter
*/
export interface PopoverItemDelimiter {
export interface PopoverItemDelimiterParams {
/**
* Item type
*/
Expand All @@ -12,7 +12,7 @@ export interface PopoverItemDelimiter {
/**
* Common parameters for both types of popover items: with or without confirmation
*/
interface PopoverItemBase {
interface PopoverItemBaseParams {
/**
* Item type
*/
Expand Down Expand Up @@ -55,8 +55,8 @@ interface PopoverItemBase {
name?: string;

/**
* Defines whether item should toggle on click.
* Can be represented as boolean value or a string key.
* Defines whether item should toggle on click.
* Can be represented as boolean value or a string key.
* In case of string, works like radio buttons group and highlights as inactive any other item that has same toggle key value.
*/
toggle?: boolean | string;
Expand All @@ -65,20 +65,20 @@ interface PopoverItemBase {
/**
* Represents popover item with confirmation state configuration
*/
export interface PopoverItemWithConfirmation extends PopoverItemBase {
export interface PopoverItemWithConfirmationParams extends PopoverItemBaseParams {
/**
* Popover item parameters that should be applied on item activation.
* May be used to ask user for confirmation before executing popover item activation handler.
*/
confirmation: PopoverItemDefault;
confirmation: PopoverItemDefaultParams;

onActivate?: never;
}

/**
* Represents popover item without confirmation state configuration
*/
export interface PopoverItemWithoutConfirmation extends PopoverItemBase {
export interface PopoverItemWithoutConfirmationParams extends PopoverItemBaseParams {
confirmation?: never;

/**
Expand All @@ -87,36 +87,36 @@ export interface PopoverItemWithoutConfirmation extends PopoverItemBase {
* @param item - activated item
* @param event - event that initiated item activation
*/
onActivate: (item: PopoverItem, event?: PointerEvent) => void;
onActivate: (item: PopoverItemParams, event?: PointerEvent) => void;

}


/**
* Represents popover item with children (nested popover items)
*/
export interface PopoverItemWithChildren extends PopoverItemBase {
export interface PopoverItemWithChildrenParams extends PopoverItemBaseParams {
confirmation?: never;
onActivate?: never;

/**
* Items of nested popover that should be open on the current item hover/click (depending on platform)
*/
children?: {
items: PopoverItem[]
items: PopoverItemParams[]
}
}

/**
* Default, non-delimiter popover item type
*/
export type PopoverItemDefault =
PopoverItemWithConfirmation |
PopoverItemWithoutConfirmation |
PopoverItemWithChildren;
export type PopoverItemDefaultParams =
PopoverItemWithConfirmationParams |
PopoverItemWithoutConfirmationParams |
PopoverItemWithChildrenParams;

/**
* Represents single popover item
*/
export type PopoverItem = PopoverItemDefault | PopoverItemDelimiter;
export type PopoverItemParams = PopoverItemDefaultParams | PopoverItemDelimiterParams;

2 changes: 1 addition & 1 deletion src/components/utils/popover/popover-abstract.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import EventsDispatcher from '../events';
import Listeners from '../listeners';
import { PopoverEventMap, PopoverMessages, PopoverParams, PopoverEvent, PopoverNodes } from './popover.types';
import { css } from './popover.const';
import { PopoverItem as PopoverItemParams } from '../../../../types';
import { PopoverItemParams } from './components/popover-item';

/**
* Class responsible for rendering popover and handling its behaviour
Expand Down
3 changes: 1 addition & 2 deletions src/components/utils/popover/popover-mobile.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ import ScrollLocker from '../scroll-locker';
import { PopoverHeader } from './components/popover-header';
import { PopoverStatesHistory } from './utils/popover-states-history';
import { PopoverMobileNodes, PopoverParams } from './popover.types';
import { PopoverItemDefault } from './components/popover-item';
import { PopoverItem as PopoverItemParams } from '../../../../types';
import { PopoverItemDefault, PopoverItemParams } from './components/popover-item';
import { css } from './popover.const';
import Dom from '../../dom';

Expand Down
2 changes: 1 addition & 1 deletion types/configs/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ export * from './conversion-config';
export * from './log-levels';
export * from './i18n-config';
export * from './i18n-dictionary';
export * from './popover'
export * from '../../src/components/utils/popover/components/popover-item/popover-item.types';
11 changes: 8 additions & 3 deletions types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,15 @@ export {
Dictionary,
DictValue,
I18nConfig,
PopoverItem,
PopoverItemWithConfirmation,
PopoverItemWithoutConfirmation
} from './configs';

export {
PopoverItemParams,
PopoverItemDefaultParams,
PopoverItemWithConfirmationParams,
PopoverItemWithoutConfirmationParams
} from '../src/components/utils/popover/components/popover-item';

export { OutputData, OutputBlockData} from './data-formats/output-data';
export { BlockId } from './data-formats/block-id';
export { BlockAPI } from './api'
Expand Down
4 changes: 2 additions & 2 deletions types/tools/tool-settings.d.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ToolConfig } from './tool-config';
import { ToolConstructable, BlockToolData } from './index';
import { PopoverItem } from '../configs';
import { PopoverItemParams } from '../configs';

/**
* Tool may specify its toolbox configuration
Expand Down Expand Up @@ -32,7 +32,7 @@ export interface ToolboxConfigEntry {
/**
* Represents single Tunes Menu item
*/
export type TunesMenuConfigItem = PopoverItem & {
export type TunesMenuConfigItem = PopoverItemParams & {
/**
* Tune displayed text.
*/
Expand Down