Skip to content

Not run/Skipped test reporting#13

Open
knekylen-smith wants to merge 4 commits into
codice:masterfrom
knekylen-smith:NotRunTestReporting
Open

Not run/Skipped test reporting#13
knekylen-smith wants to merge 4 commits into
codice:masterfrom
knekylen-smith:NotRunTestReporting

Conversation

@knekylen-smith

Copy link
Copy Markdown

Created a reporter that notifies when tests are not executed after max time is reached.

@knekylen-smith knekylen-smith changed the title Created a reporter that notifies when tests are not executed after ma… Not run/Skipped test reporting May 18, 2023
@jhunzik
jhunzik requested review from dcruver and mcalcote May 18, 2023 17:21
Comment thread codice-itest-impl/src/main/java/org/codice/itest/SkipAwareExecutorService.java Outdated
@mcalcote

Copy link
Copy Markdown
Contributor

@knekylen-smith Are there any hero instructions that can be included in the description?

@knekylen-smith

knekylen-smith commented May 18, 2023

Copy link
Copy Markdown
Author

@knekylen-smith Are there any hero instructions that can be included in the description?

To be honest I am not sure. Building it was a success and testing it would require a case where one test runs past the max time allowing for another test to not be run to see it in action.

Comment thread codice-itest-impl/src/main/java/org/codice/itest/SkipAwareExecutorService.java Outdated
@mcalcote

Copy link
Copy Markdown
Contributor

@dcruver I noticed the new classes didn't have the Codice header info. Is that required?

@jhunzik

jhunzik commented May 18, 2023

Copy link
Copy Markdown
Contributor

@knekylen-smith Are there any hero instructions that can be included in the description?

To be honest I am not sure. Building it was a success and testing it would require a case where one test runs past the max time allowing for another test to not be run to see it in action.

You could probably just set the time limit very low and a sleep that exceeds it in an itest.

@knekylen-smith

knekylen-smith commented May 19, 2023

Copy link
Copy Markdown
Author

@knekylen-smith Are there any hero instructions that can be included in the description?

To be honest I am not sure. Building it was a success and testing it would require a case where one test runs past the max time allowing for another test to not be run to see it in action.

You could probably just set the time limit very low and a sleep that exceeds it in an itest.

Good idea I will try that

@knekylen-smith
knekylen-smith deleted the NotRunTestReporting branch May 19, 2023 13:29
@knekylen-smith
knekylen-smith restored the NotRunTestReporting branch May 19, 2023 13:29

@jhunzik jhunzik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to test this somehow to confirm that the new reporting works? Also, I know this project doesn't have a lot of testing, but it could help to add some units tests to prevent regression going forward.

@knekylen-smith

Copy link
Copy Markdown
Author

I am working on testing that method that you suggested. I haven't officially made progress as I started working on something else, but I will implement the changes you guys are suggesting and also test them out today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants