Skip to content

Format error logs#85

Merged
kacpersaw merged 5 commits intomasterfrom
format-error-logs
May 13, 2020
Merged

Format error logs#85
kacpersaw merged 5 commits intomasterfrom
format-error-logs

Conversation

@kacpersaw
Copy link
Contributor

@kacpersaw kacpersaw commented May 13, 2020

Add pretty-print for resource error and format runtime error.

@kacpersaw kacpersaw requested a review from mwierzbicki May 13, 2020 08:45
mwierzbicki
mwierzbicki approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@mwierzbicki mwierzbicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tested.

@boscard
Copy link
Contributor

boscard commented May 13, 2020 •
edited
Loading

Can you provide example output?

@kacpersaw
Copy link
Contributor Author

kacpersaw commented May 13, 2020

@boscard

INFO[0000] Syncing pipelines...                         
ERRO[0001] Status: 400, Error: Bad Request, Message: A pipeline with name Example pipeline from JsonnetPipeline already exists in application jsonnetappTest
FATA[0001] failed to sync pipeline: "Example pipeline from JsonnetPipeline"

@kacpersaw kacpersaw merged commit 8461241 into master May 13, 2020
@kacpersaw kacpersaw deleted the format-error-logs branch May 13, 2020 09:45
@kacpersaw kacpersaw mentioned this pull request May 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mwierzbicki mwierzbicki mwierzbicki approved these changes

@boscard boscard boscard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kacpersaw @boscard @mwierzbicki