Skip to content

fix: tighten up mcp build - #674

Merged
CarsonRoscoe merged 2 commits into
mainfrom
fix/ts-cli-mcp-build
Apr 15, 2025
Merged

fix: tighten up mcp build#674
CarsonRoscoe merged 2 commits into
mainfrom
fix/ts-cli-mcp-build

Conversation

@CarsonRoscoe

Copy link
Copy Markdown
Contributor

Description

A builder ran into an error that showed us that our build constraints were too loose. In certain environments, a CJS build would be created, and in others, a ESM.

This PR locks down the build step so it no longer relies on whichever tsc npm chooses to use, and instead enforces a tsup build. Choices made were inspired by this code.

Tests

Before, whether I used tsc or npx tsc, I could switch between cjs or esm builds getting compiled. Now, no matter the node version, the global typescript compiler installed, I get a consistent esm build.

Checklist

  • Added a changelog entry

@CarsonRoscoe
CarsonRoscoe marked this pull request as ready for review April 15, 2025 10:24
@cb-heimdall

cb-heimdall commented Apr 15, 2025

Copy link
Copy Markdown

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@CarsonRoscoe
CarsonRoscoe requested a review from 0xRAG April 15, 2025 10:24
@github-actions github-actions Bot added documentation Improvements or additions to documentation typescript labels Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation typescript

Development

Successfully merging this pull request may close these issues.

3 participants