Add toMap and toJson methods to BuildInfo#958
Merged
lefou merged 3 commits intocom-lihaoyi:masterfrom Sep 8, 2020
Merged
Conversation
lefou
reviewed
Sep 4, 2020
Member
lefou
left a comment
There was a problem hiding this comment.
Mill uses upickle for JSON serialization. The circe version is probably only present for some contrib module.
Member
|
I don't think we should hardcode a ujson dependency in the BuildInfo modules. If anyone wants to convert it to JSON, calling |
Member
|
+1 for only adding the Edited: Removed the idea about pre-rendered JSON |
Contributor
Author
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON is done via
ujson-circeas this is what's already being used in the project itself