Merged
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
sergio-mena
approved these changes
Mar 1, 2023
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
LGTM.
Could you add a small sentence in RELEASES.md mentioning this check in the step we say "bump the version"?
Contributor
Author
Sure thing! I'll do this in a separate PR to |
Signed-off-by: Thane Thomson <connect@thanethomson.com>
This reverts commit 6bed987.
lasarojc
approved these changes
Mar 1, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that I forgot to bump the version number in #404, this PR:
release/**)I first created a branch reference with no changes and pushed it, resulting in this failed job: https://github.com/cometbft/cometbft/actions/runs/4304426331/jobs/7505444362
Now I've updated
version/version.go, resulting in the passing job here: https://github.com/cometbft/cometbft/actions/runs/4304443882/jobs/7505482959PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments