Skip to content

Release v0.37.0-rc4#431

Merged
thanethomson merged 4 commits intov0.37.xfrom
release/v0.37.0-rc4
Mar 1, 2023
Merged

Release v0.37.0-rc4#431
thanethomson merged 4 commits intov0.37.xfrom
release/v0.37.0-rc4

Conversation

@thanethomson
Copy link
Copy Markdown
Contributor

@thanethomson thanethomson commented Mar 1, 2023

Given that I forgot to bump the version number in #404, this PR:

  1. Bumps the version number
  2. Tests the release version number check in CI for release branches (all pushes to release/**)
  3. Enforces the version check when we push tags

I first created a branch reference with no changes and pushed it, resulting in this failed job: https://github.com/cometbft/cometbft/actions/runs/4304426331/jobs/7505444362

Now I've updated version/version.go, resulting in the passing job here: https://github.com/cometbft/cometbft/actions/runs/4304443882/jobs/7505482959


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson added the release Pull requests that facilitate cutting a release label Mar 1, 2023
@thanethomson thanethomson marked this pull request as ready for review March 1, 2023 14:19
@thanethomson thanethomson requested a review from a team as a code owner March 1, 2023 14:19
Copy link
Copy Markdown
Collaborator

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Could you add a small sentence in RELEASES.md mentioning this check in the step we say "bump the version"?

@thanethomson
Copy link
Copy Markdown
Contributor Author

Could you add a small sentence in RELEASES.md mentioning this check in the step we say "bump the version"?

Sure thing! I'll do this in a separate PR to main and backport it across the release branches.

@thanethomson thanethomson merged commit 735f6e1 into v0.37.x Mar 1, 2023
@thanethomson thanethomson deleted the release/v0.37.0-rc4 branch March 1, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Pull requests that facilitate cutting a release

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants