fix: device name change doesn't update immediately#645
Open
athospy wants to merge 1 commit into
Open
Conversation
When a device name is changed, ACTION_UPDATE_DEVICE updates state.devices[] but left state.device stale. Components reading state.device (DeviceInfo, CommacareBadge) would not re-render until remount, making the name change appear to have no effect. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Welcome to connect! Make sure to:
deployed preview: https://645.connect-d5y.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #641.
Root cause
ACTION_UPDATE_DEVICEupdatesstate.devices[]but leavesstate.devicestale.Components that read from
state.devicevia Obstruction (e.g.DeviceInfo,CommacareBadge) never see the new name until they remount — so renaming a deviceappears to have no effect until a page reload.
ACTION_UPDATE_DEVICES(the bulk list refresh) already handles this correctly bysyncing
state.deviceafter updating the array. This applies the same pattern tothe single-device update action.
Fix
3 lines in
src/reducers/globalState.js: after updating the device instate.devices[],also update
state.deviceif the updated device is the currently selected one.