Add ModalDialog component and useModalDialog hook#1104
Draft
Conversation
✅ Deploy Preview for commercelayer-app-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ModalDialog component and useModalDialog hook
bd729f3 to
6993dee
Compare
860f548 to
5b3bd60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes commercelayer/issues-app#588
Summary
Introduces a reusable hook (
useModalDialog), designed for delete and confirm flows that must prevent any other interaction until the user explicitly chooses.Changes
Modal(extended, backward-compatible)Two optional props added to
ModalProps:closeOnBackdrop?: boolean— defaults totrue; set tofalseto prevent backdrop-click dismissalcloseOnEscape?: boolean— defaults totrue; set tofalseto prevent Escape-key dismissalModalDialog(new composite component not exported - only to be used internally)A blocking dialog built on
Modalwith a fixed layout: icon → title → optional description → confirm button → Cancel button.Props:
showbooleanonClose() => voidiconIconProps["name"]titlestringdescriptionReactNodeconfirmModalDialogConfirmProps{ label, variant?, onClick: () => Promise }errorMessagestring | (err) => stringsuccessMessagestringBehaviour:
errortoast then closesuseModalDialog(new hook)Follows the existing
useOverlayfamily convention.Stories
Modal.stories.tsx— removedAsDialogstory (superseded)useModalDialog.stories.tsx(new) — three stories:ConfirmAction,DeleteAction,AsyncError