Skip to content

Update danger variant styles for Button and A components #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gciotola wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −6
Open

Update danger variant styles for Button and A components #1105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26e7573
fix: update danger variant styles for Button and Anchor components
gciotola Apr 30, 2026
bdea6e4
chore: force compatible version of pkg-pr-new@0.0.68
gciotola Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pkg-pr-new.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ jobs:

- name: Publish 🚀 pkg.pr.new
run: |
npx pkg-pr-new publish './packages/app-elements' --no-template
npx pkg-pr-new@0.0.68 publish './packages/app-elements' --no-template
4 changes: 2 additions & 2 deletions packages/app-elements/src/ui/atoms/A.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ describe("Anchor", () => {
click me
</A>,
)
expect(getByRole("link").className).toContain("bg-white")
expect(getByRole("link").className).toContain("text-red")
expect(getByRole("link").className).toContain("bg-red")
expect(getByRole("link").className).toContain("text-white")
expect(getByRole("link").className).toContain("border border-red")
})

Expand Down
4 changes: 2 additions & 2 deletions packages/app-elements/src/ui/atoms/Button.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ describe("Button", () => {

it("Should render as danger variant", () => {
const { getByRole } = render(<Button variant="danger">click me</Button>)
expect(getByRole("button").className).toContain("bg-white")
expect(getByRole("button").className).toContain("text-red")
expect(getByRole("button").className).toContain("bg-red")
expect(getByRole("button").className).toContain("text-white")
expect(getByRole("button").className).toContain("border border-red")
})

Expand Down
3 changes: 2 additions & 1 deletion packages/app-elements/src/ui/internals/InteractiveElement.className.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ function getVariantCss(
"bg-white border border-gray-200 text-black hover:opacity-80 hover:bg-gray-50",
circle:
"bg-white text-black hover:opacity-80 hover:bg-gray-50 rounded-full",
danger: "font-medium bg-white border border-red text-red hover:bg-red/10",
danger:
"font-medium bg-red border border-red text-white hover:bg-red-300 hover:border-red-300",
link: "font-semibold text-primary hover:text-primary-light border-primary-light cursor-pointer",
relationship: "text-primary border border-gray-300 border-dashed",
input:
Expand Down
Loading