fix(MyAccountLink): add returnUrl prop + fix HostedCart minicart glitch#747
Merged
fix(MyAccountLink): add returnUrl prop + fix HostedCart minicart glitch#747
Conversation
…gout in My Account Closes #687
- Replace open !== isOpen check with prevOpenRef to only call setOpen when the open prop itself changes, not on unrelated effect re-runs - Fix subscription leak: store openCartHandler in a named variable so unsubscribe passes the same reference as subscribe Closes #686 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace synchronous href + onClick with useEffect that resolves org config on mount, falling back to getApplicationLink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Backport of fixes from #740 onto
v5.0.0.🐛 Fix: MyAccountLink — add
returnUrlprop (Closes #687)Adds
returnUrl?: stringprop toMyAccountLink. Passes it throughgetOrganizationConfigparams so mfe-my-account can render the "back to store" link and handle logout redirect.🐛 Fix: HostedCart — minicart glitch on first visit (Closes #686)
On first visit with no orderId, the minicart was opening and closing immediately due to a race condition with
createOrder(). Fixed withprevOpenRefto only callsetOpenwhen theopenprop itself changes. Also fixed subscription leak inunsubscribe.♻️ Refactor: MyAccountLink — useEffect pattern (like MyIdentityLink)
Replace synchronous
href+onClickwith auseEffectthat resolves org config on mount, falling back togetApplicationLink.