IP version selection: v4, v6, both#448
IP version selection: v4, v6, both#448StLyn4 wants to merge 1 commit intocomplexorganizations:mainfrom
Conversation
Signed-off-by: Vsevolod Volkov <st.lyn4@gmail.com>
|
Please specify in more detail what exactly needs to be simplified. As soon as I have free time, I will try to do it. 😊 As for the current state, I tried to preserve the original logic of the script and at the moment all the changes can be described as follows: I simply added 2 flags: IP_V4_ENABLED and IP_V6_ENABLED. After that, I wrapped the code specific to these versions in "if IP_Vx_ENABLED". I also preliminarily divided some code into 2 parts by IP versions, while maintaining the same logic. As for deeper changes:
|
|
This was my need exactly, as I needed quick and dirty way to set up only for ipv4 on test environment i used code from this pr and have encountered a bug Unfortunately I lack time and skill in bash but per my understanding this is what the code is trying to do 10.0.0.2 + 1 instead of 2 + 1 P.S your work is much appreciated 🤘🤘 |
I think the title speaks for itself. Basically, another option has been added to the initial setup process, which allows you to choose between using IPv4 only, IPv6, or both (as it was before).
Why?
There are still quite a few places where only IPv4 is available (for example, almost everywhere in my country).
I have also come across some cheap configurations where only IPv6 is available, and IPv4 is disabled.
I would be happy to get feedback and make corrections if necessary.
Have a nice day! :)