Skip to content

ember-template-engine added to main tag in Bower.json for wiredep errors.#69

Merged
rwjblue merged 2 commits intocomponents:masterfrom
usmantahirr:master
Apr 13, 2015
Merged

ember-template-engine added to main tag in Bower.json for wiredep errors.#69
rwjblue merged 2 commits intocomponents:masterfrom
usmantahirr:master

Conversation

@usmantahirr
Copy link
Contributor

Added Ember Template Engine to Bower, WireDep plugin don't include this component if its not in main hence templates won't compile.

For templates compilation its required or it throws an error "Uncaught Error: Cannot call compile without the template compiler loaded. Please load ember-template-compiler.js prior to calling compile"

…is component if its not in main hence templates won't compile.

For templates compilation its required or it throws an error "Uncaught Error: Cannot call `compile` without the template compiler loaded. Please load `ember-template-compiler.js` prior to calling `compile`"
bower.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the indentation above, and remove the extra newline?

@rwjblue
Copy link
Contributor

rwjblue commented Apr 13, 2015

Can you also update the auto-generated file in emberjs/ember.js here:

https://github.com/emberjs/ember.js/blob/master/config/package_manager_files/bower.json

@usmantahirr
Copy link
Contributor Author

Sure. Give me a minute.

@usmantahirr
Copy link
Contributor Author

Pushed changes in this repo. Now forking and fixing in https://github.com/emberjs/ember.js/blob/master/config/package_manager_files/bower.json

@rwjblue
Copy link
Contributor

rwjblue commented Apr 13, 2015

Thank you!

rwjblue added a commit that referenced this pull request Apr 13, 2015
ember-template-engine added to main tag in Bower.json for wiredep errors.
@rwjblue rwjblue merged commit 76cbce0 into components:master Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants