Update CF connector to implement new Connector interface - #273
Merged
Conversation
Signed-off-by: IvanChalukov <ichalukov@gmail.com>
Signed-off-by: IvanChalukov <ichalukov@gmail.com>
|
Validated by building Concourse with: replace github.com/concourse/dex => github.com/IvanChalukov/dex v0.0.0-20260518155201-990c8426ee83then I replaced the binary on our Concourse bosh web instance and stopped the HA web instance to test cloudfoundry auth trough the modified binary instance. Thanks for the fix. |
Member
|
note to future self: we should do these PR's directly into the relevant I'm now cherry-picking the commits over to the relevant |
Author
|
Sorry for the double work @taylorsilva, I did not know that specification. I will keep that in mind next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
related concourse/concourse#9577
Update callback connector API and CF implementation.
Special notes for your reviewer
Validation:
go test ./connector/cloudfoundry