-
-
Notifications
You must be signed in to change notification settings - Fork 108
Rerender the 3.6 branch to use clang 9 and vs2017 #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nda-forge-pinning 2019.10.11
…nda-forge-pinning 2019.11.01
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
all succeed, maybe just disable appveyor in conda-forge.yml ? |
|
replace 'appveyor' by 'default' in conda-forge.yml and rerender |
|
Thanks! Let's see what happens now... |
|
you must replace appveyor by default in the provider line, then rerender |
|
Hmmm... that didn't seem to help |
|
see: |
This reverts commit 5d76d94.
|
Like this? |
|
@conda-forge-admin please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you, but it looks like I wasn't able to push to the clang9 branch of rggjan/python-feedstock. Did you check the "Allow edits from maintainers" box? |
|
Why does it still run appveyor? |
|
the rerendering failed, can you check the Allow edits from maintainers" box? |
|
This box is checked (and was checked from the beginning...). Not sure what's wrong. Feel free to fork (or merge my changes into your original PR) if this helps... |
|
Appveyor is irrelevant here. |
|
This looks good to me, but I would appreciate more eyes |
|
@conda-forge-admin please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you, but it looks like I wasn't able to push to the clang9 branch of rggjan/python-feedstock. Did you check the "Allow edits from maintainers" box? |
|
We built 3.6 with VS2015 and why change this now? |
|
It didn't build anymore with vs2015. See this comment by @mariusvniekerk: |
|
Anyone has another idea how to fix the |
You can install |
…nda-forge-pinning 2019.11.26
|
Hmm... the |
Well, the rerender was only necessary to remove appveyor. Now you could theoretically re-add your VS2017 changes. For making it "rerender-proof", the README under
|
|
I don't know whether switching from VS2015 to VS2017 is a good idea. For example, what happens to downstream packages? Will they be using VS2017 or VS2015? Will they be compatible? |
|
Besides, #275 works in appveyor with VS2015 |
|
Done in #275 |
Trying to get this to work:
#275
by building with vs2017 for windows (#275 (comment))