Skip to content

Conversation

@rggjan
Copy link

@rggjan rggjan commented Nov 18, 2019

Trying to get this to work:
#275

by building with vs2017 for windows (#275 (comment))

@rggjan rggjan requested a review from pelson as a code owner November 18, 2019 09:27
@rggjan rggjan changed the title Clang9 Rerender the 3.6 branch to use clang 9 and vs2017 Nov 18, 2019
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jschueller
Copy link
Contributor

jschueller commented Nov 26, 2019

all succeed, maybe just disable appveyor in conda-forge.yml ?

@jschueller
Copy link
Contributor

replace 'appveyor' by 'default' in conda-forge.yml and rerender

@rggjan
Copy link
Author

rggjan commented Nov 26, 2019

Thanks! Let's see what happens now...

@jschueller
Copy link
Contributor

you must replace appveyor by default in the provider line, then rerender

@rggjan
Copy link
Author

rggjan commented Nov 27, 2019

Hmmm... that didn't seem to help

@jschueller
Copy link
Contributor

see:

provider: {linux_aarch64: default, linux_ppc64le: default, win: appveyor}

@rggjan
Copy link
Author

rggjan commented Nov 27, 2019

Like this?

@jschueller
Copy link
Contributor

@conda-forge-admin please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like I wasn't able to push to the clang9 branch of rggjan/python-feedstock. Did you check the "Allow edits from maintainers" box?

@rggjan
Copy link
Author

rggjan commented Nov 27, 2019

Why does it still run appveyor?

@jschueller
Copy link
Contributor

the rerendering failed, can you check the Allow edits from maintainers" box?

@rggjan
Copy link
Author

rggjan commented Nov 27, 2019

This box is checked (and was checked from the beginning...). Not sure what's wrong. Feel free to fork (or merge my changes into your original PR) if this helps...

@scopatz
Copy link
Member

scopatz commented Nov 27, 2019

Appveyor is irrelevant here.

@scopatz
Copy link
Member

scopatz commented Nov 27, 2019

This looks good to me, but I would appreciate more eyes

@jschueller
Copy link
Contributor

@conda-forge-admin please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like I wasn't able to push to the clang9 branch of rggjan/python-feedstock. Did you check the "Allow edits from maintainers" box?

@isuruf
Copy link
Member

isuruf commented Nov 27, 2019

We built 3.6 with VS2015 and why change this now?

@rggjan
Copy link
Author

rggjan commented Nov 28, 2019

It didn't build anymore with vs2015. See this comment by @mariusvniekerk:
#275 (comment)

@rggjan
Copy link
Author

rggjan commented Nov 28, 2019

Anyone has another idea how to fix the AppVeyor build failed?

@h-vetinari
Copy link
Member

Anyone has another idea how to fix the AppVeyor build failed?

You can install conda-smithy and run conda smithy rerender locally (since the bot can't push to your branch). Then you can commit the changes that should remove the AppVeyor job yourself.

@rggjan
Copy link
Author

rggjan commented Nov 28, 2019

Hmm... the conda-smithy rerender undid my visual studio changes... how do I make conda-smithy use visual studio 2017?

@h-vetinari
Copy link
Member

Hmm... the conda-smithy rerender undid my visual studio changes... how do I make conda-smithy use visual studio 2017?

Well, the rerender was only necessary to remove appveyor. Now you could theoretically re-add your VS2017 changes. For making it "rerender-proof", the README under .ci_support gives a hint:

This file is automatically generated by conda-smithy. To change any matrix elements, you should change conda-smithy's input conda_build_config.yaml and re-render the recipe, rather than editing these files directly.

@isuruf
Copy link
Member

isuruf commented Nov 28, 2019

I don't know whether switching from VS2015 to VS2017 is a good idea. For example, what happens to downstream packages? Will they be using VS2017 or VS2015? Will they be compatible?

@isuruf
Copy link
Member

isuruf commented Nov 28, 2019

Besides, #275 works in appveyor with VS2015

@rggjan
Copy link
Author

rggjan commented Nov 29, 2019

Besides, #275 works in appveyor with VS2015

But why is #275 failing then? And how to fix it?

@isuruf
Copy link
Member

isuruf commented Dec 6, 2019

Done in #275

@isuruf isuruf closed this Dec 6, 2019
@rggjan rggjan mentioned this pull request Aug 3, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants