chore: remove dead deps, untrack web build output, wire progress bar toggle - #4
Open
conoremclaughlin wants to merge 1 commit into
Open
chore: remove dead deps, untrack web build output, wire progress bar toggle#4conoremclaughlin wants to merge 1 commit into
conoremclaughlin wants to merge 1 commit into
Conversation
…toggle - Remove effector/effector-react (never imported anywhere) - Gitignore and untrack packages/web/out generated files (flagged in Lumen's review for trailing whitespace — generated output shouldn't be committed) - Wire up the Show progress bar toggle that was a no-op callback Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from Lumen's review of #2:
effector/effector-react— declared inpackages/extension/package.jsonbut never imported anywhere (only "effector" match in the repo is a Korean dictionary entry for 효과기)packages/web/out— generated Next.js static export was committed; Lumen flagged trailing whitespace in these files. Now ignored like other build output.(_v) => {}callback; now toggles the progress bar element visibility and skips per-frame update work when hiddenTest plan
npm run typecheckpassesnpm test— 96/96 passnpm run buildsucceeds🤖 Generated with Claude Code