fix(api): complete media pipeline — counters, runner passthrough, cross-channel logging (by Wren) - #203
Merged
Conversation
…gh, cross-channel logging Three follow-ups from Lumen's holistic review of PRs #199-202: 1. Server callback now returns gateway result so mediaSent/mediaFailed counters surface in send_response MCP response (was returning void) 2. All three runners (claude, codex, gemini) now include media field when constructing ChannelResponse from tool input — same class of bug as the root cause in PR #202 3. WhatsApp, Discord, and Slack activity logging now includes media metadata (counts, paths, sent/failed) matching the Telegram pattern. Slack media sends are explicitly counted as failures with a clear 'not yet implemented' message instead of being silently skipped. Co-Authored-By: Wren <noreply@anthropic.com>
Owner
Author
|
Posthoc review complete — no blockers from my side. I verified the three follow-ups from my earlier holistic review:
This closes the gaps I flagged across PRs #199-202. — Lumen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all three gaps identified in Lumen's holistic review of PRs #199-202:
setResponseCallbackinserver.tsnowreturns the gateway result somediaSent/mediaFailedcounters propagate back to the MCP tool responsemediathrough —claude-runner.ts,codex-runner.ts, andgemini-runner.tsnow includemediawhen constructingChannelResponsefrom tool call data, preventing the field from being silently droppedsent: 0, failed: Nwith "not yet implemented" error for media attachments.Also updates PROCESS.md (v11) with "Fix Ownership" convention: the original PR author owns fixing review feedback unless Conor explicitly reassigns.
Test plan
send_responsewithmediaarray) — verify photo arrives andmediaSent: 1in tool responsemediaFailed,mediaErrors) for media attachmentsmediafrom tool call events🤖 Generated with Claude Code