Refactor: Replace BitVec dependency with plain bool vectors#10
Open
jbeyerstedt wants to merge 4 commits intomainfrom
Open
Refactor: Replace BitVec dependency with plain bool vectors#10jbeyerstedt wants to merge 4 commits intomainfrom
jbeyerstedt wants to merge 4 commits intomainfrom
Conversation
jbeyerstedt
commented
Mar 4, 2026
jbeyerstedt
commented
Mar 4, 2026
jbeyerstedt
commented
Mar 4, 2026
Also fixes encoding issues with bit vectors and introduces explicit functions to encode an decode SEQUENCE preambles
jbeyerstedt
force-pushed
the
chore/remove-bitvec-dependency
branch
from
51b61e2 to
805838d
Compare
jbeyerstedt
force-pushed
the
chore/remove-bitvec-dependency
branch
from
805838d to
e6fc2b5
Compare
jbeyerstedt
force-pushed
the
chore/remove-bitvec-dependency
branch
from
e6fc2b5 to
6fe7c1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bitvec crate seems to be unmaintained and is not compatible with the latest Nom release (if we need to update at some point).
It also doesn't help us quite so much here since most of the data is byte aligned anyways, so I would rather have less dependencies and a bit more code.
I added a dependency on
arbitrary-intthough to properly represent the 4, 5 and 15 bit values we have.TODO: