Upgrade to terminal_size v0.2#133
Closed
benesch wants to merge 1 commit into
Closed
Conversation
Collaborator
|
That version uses different dependencies to libc and winapi. So, doing this now without changing our own dependencies just adds more dependencies to compile time for not much benefit. |
Author
|
Will you accept a revision that does the version upgrade of terminal_size
and also ports console over to rustix and windows-sys? If so please reopen.
…On Mon, Sep 19, 2022 at 4:29 AM Pavan Kumar Sunkara < ***@***.***> wrote:
That version uses different dependencies to libc and winapi. So, doing
this now without changing our own dependencies just adds more dependencies
to compile time for not much benefit.
—
Reply to this email directly, view it on GitHub
<#133 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGXSIBQ2YQG3R3AHKW4AMLV7AP6FANCNFSM6AAAAAAQPX6S7I>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
Thanks! I'll take a look at this when I can. |
Author
|
Ah, never mind. I'm afraid I just won't have the time. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.