Skip to content

Timeline panning bug fix#499

Merged
arcturus2 merged 2 commits intomasterfrom
timeline-box
May 11, 2020
Merged

Timeline panning bug fix#499
arcturus2 merged 2 commits intomasterfrom
timeline-box

Conversation

@antares1470
Copy link
Collaborator

Description of the Change

Added a fix for the bug in the timeline view where the box in the summary window would shrink when panning the timeline past the bounds of the of the summary window.

Alternate Designs

Why Should This Be In Core?

Fix for a bug in a feature of Core

Benefits

Possible Drawbacks

Verification Process

  1. Open a new graph and create a sphere graph
  2. Open timeline view ensuring that summary window is visible
  3. Pan timeline across and observe box in summary view doesn't change its size when going past summary window bounds
  4. Verify that the expected ways to change the size of the box (e.g. zooming) still behave as expected

Applicable Issues

#498

@antares1470 antares1470 linked an issue May 11, 2020 that may be closed by this pull request
1 task
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@arcturus2 arcturus2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was able to get the window to shrink trying to drag it beyond the end of the timeline but when I tried to gif it, it wouldn't happen again (so I guess it never happened 😄). It is very hard to break it now so approving this too.

@arcturus2 arcturus2 merged commit 96c5c5d into master May 11, 2020
@arcturus2 arcturus2 deleted the timeline-box branch May 11, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Timeline summary box shrinks when panning timeline past summary bounds

3 participants