cri: deprecate restore in CreateContainer

[samuelkarp]

No description provided.

[Copilot]

Pull request overview

This PR introduces a deprecation warning for the CRI behavior that restores checkpoint data during CreateContainer, and wires the warning service through CRI initialization so the deprecation is surfaced via warning emission and ctr deprecations list.

Changes:

• Add a new deprecation ID/message for “restoring checkpoint data during CRI CreateContainer” and document it in RELEASES.md.
• Wire the warning service into CRIServiceOptions/criService and emit/log the warning when checkpoint restore is detected in CreateContainer.
• Add unit and contrib-script coverage to verify the warning appears via introspection.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
RELEASES.md	Documents the new deprecation and target removal release.
plugins/cri/cri.go	Fetches WarningPlugin once and passes it into CRI server options.
pkg/deprecation/deprecation.go	Adds a new deprecation ID and message string.
internal/cri/server/service.go	Extends CRI service options/state to carry a warning service.
internal/cri/server/container_create.go	Emits the new deprecation warning on checkpoint-based CreateContainer.
internal/cri/server/container_checkpoint_warning_test.go	Unit test verifying warning emission for checkpoint restore.
contrib/checkpoint/checkpoint-restore-cri-test.sh	Validates warning presence/update via ctr deprecations list --format=json.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

[rst0git]

@haircommander @adrianreber Do you have any advice on how to coordinate this with CRI-O?

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

[samuelkarp]

/cherry-pick release/2.3
/cherry-pick release/2.2
/cherry-pick release/2.1

[k8s-infra-cherrypick-robot]

@samuelkarp: once the present PR merges, I will cherry-pick it on top of release/2.1, release/2.2, release/2.3 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release/2.3
/cherry-pick release/2.2
/cherry-pick release/2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[samuelkarp]

oops don't need 2.1 since that's EOL; I'll close the PR when it gets generated

[k8s-infra-cherrypick-robot]

@samuelkarp: new pull request created: #13868

Details

In response to this:

/cherry-pick release/2.3
/cherry-pick release/2.2
/cherry-pick release/2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@samuelkarp: #13838 failed to apply on top of branch "release/2.2":

Applying: cri: deprecate restore in CreateContainer
Using index info to reconstruct a base tree...
M	RELEASES.md
M	internal/cri/server/container_create.go
M	internal/cri/server/service.go
M	pkg/deprecation/deprecation.go
M	plugins/cri/cri.go
Falling back to patching base and 3-way merge...
Auto-merging RELEASES.md
CONFLICT (content): Merge conflict in RELEASES.md
Auto-merging internal/cri/server/container_create.go
Auto-merging internal/cri/server/service.go
Auto-merging pkg/deprecation/deprecation.go
CONFLICT (content): Merge conflict in pkg/deprecation/deprecation.go
Auto-merging plugins/cri/cri.go
CONFLICT (content): Merge conflict in plugins/cri/cri.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 cri: deprecate restore in CreateContainer

Details

In response to this:

/cherry-pick release/2.3
/cherry-pick release/2.2
/cherry-pick release/2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@samuelkarp: #13838 failed to apply on top of branch "release/2.1":

Applying: cri: deprecate restore in CreateContainer
Using index info to reconstruct a base tree...
M	RELEASES.md
M	contrib/checkpoint/checkpoint-restore-cri-test.sh
M	internal/cri/server/container_create.go
M	internal/cri/server/service.go
M	pkg/deprecation/deprecation.go
M	plugins/cri/cri.go
Falling back to patching base and 3-way merge...
Auto-merging RELEASES.md
CONFLICT (content): Merge conflict in RELEASES.md
Auto-merging contrib/checkpoint/checkpoint-restore-cri-test.sh
Auto-merging internal/cri/server/container_create.go
Auto-merging internal/cri/server/service.go
Auto-merging pkg/deprecation/deprecation.go
CONFLICT (content): Merge conflict in pkg/deprecation/deprecation.go
Auto-merging plugins/cri/cri.go
CONFLICT (content): Merge conflict in plugins/cri/cri.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 cri: deprecate restore in CreateContainer

Details

In response to this:

/cherry-pick release/2.3
/cherry-pick release/2.2
/cherry-pick release/2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.