Skip to content

Bump v0.53.0#1434

Merged
openshift-merge-robot merged 2 commits intocontainers:mainfrom
saschagrunert:bump-0.53.0
Apr 26, 2023
Merged

Bump v0.53.0#1434
openshift-merge-robot merged 2 commits intocontainers:mainfrom
saschagrunert:bump-0.53.0

Conversation

@saschagrunert
Copy link
Member

We require a new version to be able to use the new umask API. Therefore I'm proposing to bump to v0.53.0 (and v0.54.0-dev) in a second commit.

@Luap99
Copy link
Member

Luap99 commented Apr 26, 2023

/hold
You change seems to break podman CI: https://api.cirrus-ci.com/v1/artifact/task/5064263190970368/html/int-podman-debian-12-root-host-boltdb.log.html
I will investigate.
Did you vendor this into crio to check if the test are passing there?

We shouldn't release something that is not passing podman CI.
I have no problem with a release but we need to make sure this works correctly before.

@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 26, 2023

@Luap99 did a local test and found the regression: #1436

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

Gave it a bump on top of main.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@rhatdan PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Apr 26, 2023

/lgtm
/hold cancel

@openshift-ci openshift-ci bot added the lgtm label Apr 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit e045001 into containers:main Apr 26, 2023
@saschagrunert saschagrunert deleted the bump-0.53.0 branch April 26, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants