Skip to content

Add some fixes for CompressionFormat#1481

Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom
rhatdan:config
Jun 1, 2023
Merged

Add some fixes for CompressionFormat#1481
openshift-merge-robot merged 1 commit intocontainers:mainfrom
rhatdan:config

Conversation

@rhatdan
Copy link
Member

@rhatdan rhatdan commented May 30, 2023

No description provided.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is there any issue linked to this?

@rhatdan
Copy link
Member Author

rhatdan commented May 31, 2023

No, I am just looking into this based on comments from @giuseppe and noticed the patches in common, were not totally complete.

@rhatdan
Copy link
Member Author

rhatdan commented May 31, 2023

@giuseppe @flouthoc PTAL

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member

Luap99 commented Jun 1, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit 462ccdd into containers:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants