override DefaultInitPath for FreeBSD #1496
Merged
openshift-merge-robot merged 2 commits intocontainers:mainfrom Jun 12, 2023
Merged
override DefaultInitPath for FreeBSD #1496openshift-merge-robot merged 2 commits intocontainers:mainfrom
openshift-merge-robot merged 2 commits intocontainers:mainfrom
Conversation
This just disables the capabilities test - everything else already passed. Signed-off-by: Doug Rabson <dfr@rabson.org>
vrothberg
reviewed
Jun 12, 2023
Member
vrothberg
left a comment
vrothberg
left a comment
There was a problem hiding this comment.
Other than the nit, LGTM
Thank you!
FreeBSD packages typically install files under /usr/local on FreeBSD. Signed-off-by: Doug Rabson <dfr@rabson.org>
vrothberg
reviewed
Jun 12, 2023
Member
|
/hold cancel |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FreeBSD packages typically install files under /usr/local on FreeBSD.
This also 'fixes' pkg/config unit tests on FreeBSD - all except one test already worked and this just skips the capabilities test on FreeBSD. This may not be the right way to skip a test - I'm not at all familiar with the ginkgo test framework.