Relax name length restriction for Secrets/ConfigMaps.#1528
Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom Jun 29, 2023
Merged
Relax name length restriction for Secrets/ConfigMaps.#1528openshift-merge-robot merged 1 commit intocontainers:mainfrom
openshift-merge-robot merged 1 commit intocontainers:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes documentation states that the name of these resources much be a DNS subdomain name, which it defines[1] as being up to 253 characters. Following the referenced RFC it does appear that the name should be further restricted to require the 253 characters be made up of multiple of multiple 63-character labels separated by dots. The Kubernetes[2] validation code does not apply this label restriction though, and will accept names longer than 63 characters. This commit adjusts the length limits to match. [1]: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-subdomain-names [2]: https://github.com/kubernetes/apimachinery/blob/6b1428efc73348cc1c33935f3a39ab0f2f01d23d/pkg/util/validation/validation.go#L215 Completes: containers#1494 Signed-off-by: Kenny MacDermid <kenny@macdermid.ca> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Member
Author
|
@containers/podman-maintainers PTAL |
Member
|
LGTM |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kubernetes documentation states that the name of these resources much be a DNS subdomain name, which it defines1 as being up to 253 characters.
Following the referenced RFC it does appear that the name should be further restricted to require the 253 characters be made up of multiple of multiple 63-character labels separated by dots. The Kubernetes2 validation code does not apply this label restriction though, and will accept names longer than 63 characters.
This commit adjusts the length limits to match.
Completes: #1494