golangci.yml: enable all, disable failing linters#1631
Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom Aug 31, 2023
Merged
golangci.yml: enable all, disable failing linters#1631openshift-merge-robot merged 1 commit intocontainers:mainfrom
openshift-merge-robot merged 1 commit intocontainers:mainfrom
Conversation
golangci-lint has a number of helpful linters and new ones are being continuously added. Instead of enabling only a minimal subset of these linters, enable all by default and - for now - disable failing ones. This allows us to make use of new linters on updates and to selectively enable those we deem useful. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Member
Author
Member
|
LGTM |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint has a number of helpful linters and new ones are being continuously added. Instead of enabling only a minimal subset of these linters, enable all by default and - for now - disable failing ones. This allows us to make use of new linters on updates and to selectively enable those we deem useful.