Skip to content

Split up util package into pkg/password, pkg/copy, pkg/version#1657

Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom
rhatdan:run
Sep 20, 2023
Merged

Split up util package into pkg/password, pkg/copy, pkg/version#1657
openshift-merge-robot merged 1 commit intocontainers:mainfrom
rhatdan:run

Conversation

@rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 18, 2023

Fixes: #1654

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented Sep 18, 2023

@Luap99 Any reason why CopyDetachable is in common, seems to be only used in Podman?

@Luap99
Copy link
Member

Luap99 commented Sep 19, 2023

Because it is used by conmon-rs.

@rhatdan
Split up util package into pkg/password, pkg/detach, pkg/version
54cdbd0 
Fixes: containers#1654

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Member Author

rhatdan commented Sep 20, 2023

@mtrmac @vrothberg @Luap99 PTAL

@Luap99
Copy link
Member

Luap99 commented Sep 20, 2023

Thanks for the work!

Can you please prepare PRs for podman, buildah, skopeo, conmon-rs to address the breaking changes.

@rhatdan
Copy link
Member Author

rhatdan commented Sep 20, 2023

I will once I get this approved.

@vrothberg
Copy link
Member

vrothberg commented Sep 20, 2023

/lgtm
/hold

OK to get this in given Dan opens the PRs today

@openshift-ci openshift-ci bot added the lgtm label Sep 20, 2023
Luap99
Luap99 reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, naming is always the hard part.
/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit eb4ad85 into containers:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees

@vrothberg vrothberg

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider splitting up pkg/util into semantically-relevant subpackages

4 participants

@rhatdan @Luap99 @vrothberg @openshift-merge-robot