cgroups: remove unused files#1716
Merged
openshift-ci[bot] merged 1 commit intocontainers:mainfrom Oct 27, 2023
Merged
Conversation
Member
|
Tests blowing up? |
giuseppe
force-pushed
the
drop-unused-file
branch
from
dae2c75 to
23b453f
Compare
they are a dup of the _linux.go version. Move the linux-only functions to the _linux.go file. [NO NEW TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
drop-unused-file
branch
from
23b453f to
3d9ccf8
Compare
Member
Author
|
I had to remove even more stuff. |
Member
|
LGTM |
vrothberg
approved these changes
Oct 27, 2023
Member
vrothberg
left a comment
vrothberg
left a comment
There was a problem hiding this comment.
/lgtm
I love commits reducing the lines of code.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
they are a dup of the _linux.go version. Move the linux-only functions to the _linux.go file.
[NO NEW TESTS NEEDED]