[skip-ci] RPM: ensure config files are patched

[lsm5]

This commit copies over shortnames.conf, registries.conf and storage.conf to the rpm build dir before running the patching script.

Prior to this, the script would complain about not finding those files but the rpmbuild process itself didn't fail.

[lsm5]

@edsantiago @Luap99 @jnovy PTAL

[lsm5]

@jnovy @inknos do you know how to ensure rpmbuild fails if a script used in the setup or build stages fails to find a file? I thought -e in the script should've been enough (?)

[Luap99]

@jnovy @inknos do you know how to ensure rpmbuild fails if a script used in the setup or build stages fails to find a file? I thought -e in the script should've been enough (?)

The script exits 0 when I execute in the repo root here despite not having all the files, the reason is that the code does if grep ... so a missing file is the same as no match and the condition just goes into the else so there is never a error thrown by the script.

[lsm5]

moved zstd:chunked to rawhide and rhel > 10.

[rhatdan]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [edsantiago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jnovy]

@Luap99 In general RPM scriptlets should never fail as a it would break the whole transaction leaving the system in inconsistent state - it can put a message in the log though.

[Luap99]

@Luap99 In general RPM scriptlets should never fail as a it would break the whole transaction leaving the system in inconsistent state - it can put a message in the log though.

But we are not talking about a rpm scriptlet are we? This here patches the config files at rpm build time so we very much want to know if if failed to patch the file otherwise we install invalid config files

[lsm5]

let's make sure to get this one in before the new c/common cut tomorrow.

[edsantiago]

/lgtm

This is specfile, not scriptlet. Failing in rpmbuild is the right thing to do.

[lsm5]

/cherrypick v0.59

[jnovy]

LGTM

[travier]

d3ca62d (#2026) is missing from 0.59 and is causing issues:

• https://bodhi.fedoraproject.org/updates/FEDORA-2024-ab42dd0ffb
• zstd:chunked issues bootc-dev/bootc#509
• Add support for zstd:chunked ostreedev/ostree-rs-ext#608

See: 5c5b112#r143013047

[cgwalters]

➡️ #2048