fix(deps): update module github.com/cyphar/filepath-securejoin to v0.3.1#2096
Merged
openshift-merge-bot[bot] merged 1 commit intomainfrom Jul 23, 2024
Conversation
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, renovate[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v0.3.0->v0.3.1Release Notes
cyphar/filepath-securejoin (github.com/cyphar/filepath-securejoin)
v0.3.1Compare Source
By allowing
Open(at)InRootto opt-out of the extra work done byMkdirAllto do the necessary "partial lookups",
Open(at)InRootnow does less workfor both implementations (resulting in a many-fold decrease in the number of
operations for
openat2, and a modest improvement for non-openat2) and isfar more guaranteed to match the correct
openat2(RESOLVE_IN_ROOT)behaviour.
We now use
readlinkat(fd, "")where possible. ForOpen(at)InRootthiseffectively just means that we no longer risk getting spurious errors during
rename races. However, for our hardened procfs handler, this in theory should
prevent mount attacks from tricking us when doing magic-link readlinks (even
when using the unsafe host
/prochandle). UnfortunatelyReopenis stillpotentially vulnerable to those kinds of somewhat-esoteric attacks.
Technically this will only work on post-2.6.39 kernels
but it seems incredibly unlikely anyone is using
filepath-securejoinon apre-2011 kernel.
Several improvements were made to the errors returned by
Open(at)InRootandMkdirAllwhen dealing with invalid paths under the emulated (ie.non-
openat2) implementation. Previously, some paths would return the wrongerror (
ENOENTwhen the last component was a non-directory), and other pathswould be returned as though they were acceptable (trailing-slash components
after a non-directory would be ignored by
Open(at)InRoot).These changes were done to match
openat2's behaviour and purely is aconsistency fix (most users are going to be using
openat2anyway).Signed-off-by: Aleksa Sarai cyphar@cyphar.com
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.