RPM: No blanket conditionals for configs on COPR envs#2122
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Aug 14, 2024
Merged
RPM: No blanket conditionals for configs on COPR envs#2122openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
lsm5
force-pushed
the
copr-defaults
branch
2 times, most recently
from
6794b88 to
f196d69
Compare
lsm5
changed the title
Member
Author
|
/packit copr-build |
Member
Author
Contributor
|
LGTM |
Member
Author
Member
This used to work just fine, not sure why no longer any cirrus jobs show up here instead of marking them as skipped like it should. We cannot merge because of merge protection. I suggest you remove the skip-ci and just let CI run, it is really not so slow in c/common |
lsm5
changed the title
Given we ship podman-next copr packages on quite a few envs now, config file handling should follow distro policy as much as possible. Resolves: containers#2123 Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given we ship podman-next copr packages on quite a few envs now, config file handling should follow distro policy as much as possible.
Resolves: #2123