Add ImageListSelection to copier options#2165
Add ImageListSelection to copier options#2165openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
For artifact support, the copier needs to get all tags; as such, we need to pass in the correct value for ImageListSelection. Signed-off-by: Brent Baude <bbaude@redhat.com>
| // CopySpecificImages, to control whether, when the source reference is a list, | ||
| // copy.Image() copies only an image which matches the current runtime | ||
| // environment, or all images which match the supplied reference, or only | ||
| // specific images from the source reference. |
There was a problem hiding this comment.
(Without exposing also Instances, CopySpecificImages is not usable. But Instances is not relevant to the current use case anyway, and there’s not really a benefit to explicitly rejecting the value — anyone implementing a user of CopySpecificImages would see that it’s impossible.)
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| // CopySpecificImages, to control whether, when the source reference is a list, | ||
| // copy.Image() copies only an image which matches the current runtime | ||
| // environment, or all images which match the supplied reference, or only | ||
| // specific images from the source reference. |
There was a problem hiding this comment.
On second thought… a
// Warning: Setting this on libimage operations generally isn’t expected to work; libimage has strong assumptions on whether the copies create in single-arch or multi-arch images.would be nice to have.
3 participants
For artifact support, the copier needs to get all tags; as such, we need to pass in the correct value for ImageListSelection.