Document krunkit for AI Workloads#2200
Document krunkit for AI Workloads#2200openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
docs/containers.conf.5.md
Outdated
| | Platform | Default | Optional | | ||
| | -------- | ------------------------| -------- | | ||
| | Linux | QEMU | None | | ||
| | Windows | WSL | None | |
pkg/config/containers.conf
Outdated
| # If it is empty or commented out, the default provider will be used. | ||
| # | ||
| # Linux: QEMU (Default) | ||
| # Windows QEMU (Default) |
rhatdan
force-pushed
the
krunkit
branch
3 times, most recently
from
59e2637 to
6279837
Compare
pkg/config/containers.conf
Outdated
| # | ||
| # Linux: QEMU (Default) | ||
| # Windows: there are currently two options: | ||
| # WSL2 - Windows Subsystem for Linux (Default) |
There was a problem hiding this comment.
this is not correct we require the use of wsl not WSL2.
| # Mac: there are currently two options: | ||
| # vfkit - Default Apple Hypervisor (Default) | ||
| # krunkit - Launch virtual machines using the libkrun platform, optimized | ||
| # for sharing GPU with the machine. |
There was a problem hiding this comment.
there should be an empty comment line here to be consistent with the other descriptions above
docs/containers.conf.5.md
Outdated
| | Platform | Default | Optional | | ||
| | -------- | ---------------------------------| -------- | | ||
| | Linux | QEMU | None | | ||
| | Windows | WSL: Windows Subsystem for Linux | HyperV: Windows Server Virtualization | | ||
| | Mac | vfkit: Apple Hypervisor | krunkit: Launch machine via libkrun platform, optimized for sharing GPU with the machine | |
There was a problem hiding this comment.
I find this table confusing, as an user it is not obvious what value must be use for provider IMO. This either needs to highlight what key to use in the table or I think a list like done in containers.conf file might be better suited, especially if we ever were to add a third provider for whatever reason...
Also it may be helpful to point out that the case of the name does not matter because otherwise a user might be wondering if the case is important given all keys are written with a different case here
docs/containers.conf.5.md
Outdated
| | Platform | Default | Optional | | ||
| | -------- | ---------------------------------| -------- | | ||
| | Linux | QEMU | None | | ||
| | Windows | WSL: Windows Subsystem for Linux | HyperV: Windows Server Virtualization | | ||
| | Mac | vfkit: Apple Hypervisor | krunkit: Launch machine via libkrun platform, optimized for sharing GPU with the machine | |
There was a problem hiding this comment.
it is not called vfkit, it must use applehv
same for krunkit, you must use libkrun as provider name
pkg/config/containers.conf
Outdated
| # vfkit - Default Apple Hypervisor (Default) | ||
| # krunkit - Launch virtual machines using the libkrun platform, optimized |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
No description provided.