Revert "Move fuse-overlayfs to suggests" for all Fedoras#2206
Conversation
Commit 5ad221d ("Revert \"Move fuse-overlayfs to suggests\" for Fedora 40 and older") restored the dependency on fuse-overlayfs for Fedora 40 and older to not disrupt stable Fedora releases by breaking backwards compatibility with existing containers. Fedora completely ignores Suggests by default [1]. So, listing anything as Suggests is as good as not mentioning it at all, unless it's intended for tools and users who specifically respect it. It turns out that there are important use-cases where the Linux kernel's overlay file system doesn't work, and one could really benefit from having fuse-overlayfs(1). A container cannot use an overlayfs when the underlying file system is also an overlayfs, such as on the Fedora Workstation live media, or a network file system. Therefore, it's worth restoring the dependency on all Fedora releases to cover these use-cases. As suggested by Giuseppe Scrivano. This reverts Fedora commit 447945e59a01cb6715ed2a21877d45bf0b91ef67 for all Fedora releases. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/ Fixes: coreos/fedora-coreos-tracker#1749 Fixes: containers/toolbox#1512 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2299284 Signed-off-by: Debarshi Ray <rishi@fedoraproject.org>
|
/cc @giuseppe I didn't touch any Fedora derivatives, because I assume that it needs further discussion. |
|
Fedora Rawhide scratch build: Fedora 41 scratch build: |
|
Downstream Fedora pull requests: |
|
Thanks for doing this. We'll need a Bugzilla and a freeze exception for F41. |
|
Ah we already have both: https://bugzilla.redhat.com/show_bug.cgi?id=2299284 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debarshiray, rhatdan, travier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the quick review, @rhatdan ! |
3 participants
Commit 5ad221d ("Revert "Move fuse-overlayfs to suggests" for Fedora 40 and older") restored the dependency on fuse-overlayfs for Fedora 40 and older to not disrupt stable Fedora releases by breaking backwards compatibility with existing containers.
Fedora completely ignores Suggests by default [1]. So, listing anything as Suggests is as good as not mentioning it at all, unless it's intended for tools and users who specifically respect it.
It turns out that there are important use-cases where the Linux kernel's overlay file system doesn't work, and one could really benefit from having fuse-overlayfs(1). A container cannot use an overlayfs when the underlying file system is also an overlayfs, such as on the Fedora Workstation live media, or a network file system.
Therefore, it's worth restoring the dependency on all Fedora releases to cover these use-cases.
As suggested by Giuseppe Scrivano.
This reverts Fedora commit 447945e59a01cb6715ed2a21877d45bf0b91ef67 for all Fedora releases.
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/
Fixes: coreos/fedora-coreos-tracker#1749
Fixes: containers/toolbox#1512
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2299284